[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Virtio-fs] [PATCH 2/5] virtiofsd: prevent lo_lookup()
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [Virtio-fs] [PATCH 2/5] virtiofsd: prevent lo_lookup() NULL pointer dereference |
Date: |
Mon, 29 Jul 2019 09:15:55 +0100 |
User-agent: |
Mutt/1.12.0 (2019-05-25) |
On Fri, Jul 26, 2019 at 02:26:14PM -0700, Liu Bo wrote:
> On Fri, Jul 26, 2019 at 10:11:00AM +0100, Stefan Hajnoczi wrote:
> > Most lo_do_lookup() have already checked that the parent inode exists.
> > lo_lookup() hasn't and can therefore hit a NULL pointer dereference when
> > lo_inode(req, parent) returns NULL.
> >
>
> Sigh...this one has been fixed by 3 different developers...Me, Pengtao and
> Stefan.
>
> The following one on the ML did the exactly same thing.
> ---
> Subject: [Virtio-fs] [PATCH] virtiofsd: fix lo_do_lookup panic
>
> It needs to check for invalid parent dir.
>
> Signed-off-by: Peng Tao <address@hidden>
> ---
One of the previously posted patches will be merged before mine. It's a
shame that work has been duplicated. As a contributor I will send a
ping email if there has been no response to a patch after a few days.
Stefan
signature.asc
Description: PGP signature