[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] memory-device: not necessary to use goto fo
|
From: |
David Hildenbrand |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/3] memory-device: not necessary to use goto for the last check |
|
Date: |
Mon, 29 Jul 2019 09:30:56 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 |
On 28.07.19 15:13, Wei Yang wrote:
> We are already at the last condition check.
>
> Signed-off-by: Wei Yang <address@hidden>
> ---
> hw/mem/memory-device.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
> index 5f2c408036..df3261b32a 100644
> --- a/hw/mem/memory-device.c
> +++ b/hw/mem/memory-device.c
> @@ -186,7 +186,6 @@ static uint64_t memory_device_get_free_addr(MachineState
> *ms,
> if (!range_contains_range(&as, &new)) {
> error_setg(errp, "could not find position in guest address space for
> "
> "memory device - memory fragmented due to alignments");
> - goto out;
> }
> out:
> g_slist_free(list);
>
Reviewed-by: David Hildenbrand <address@hidden>
--
Thanks,
David / dhildenb