[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [EXTERNAL]Re: [PATCH v5 09/15] cputlb: Access MemoryReg
From: |
Aleksandar Markovic |
Subject: |
Re: [Qemu-devel] [EXTERNAL]Re: [PATCH v5 09/15] cputlb: Access MemoryRegion with MemOp |
Date: |
Fri, 26 Jul 2019 11:23:41 +0000 |
________________________________________
From: Philippe Mathieu-Daudé <address@hidden>
Sent: Friday, July 26, 2019 1:03 PM
To: address@hidden; address@hidden
Cc: address@hidden; address@hidden; address@hidden; address@hidden;
address@hidden; address@hidden; address@hidden; address@hidden; address@hidden;
Aleksandar Rikalo; address@hidden; address@hidden; address@hidden;
address@hidden; address@hidden; address@hidden; address@hidden; address@hidden;
address@hidden; address@hidden; address@hidden; address@hidden; address@hidden;
address@hidden; address@hidden; address@hidden; Aleksandar Markovic;
address@hidden; address@hidden
Subject: [EXTERNAL]Re: [Qemu-devel] [PATCH v5 09/15] cputlb: Access
MemoryRegion with MemOp
On 7/26/19 8:46 AM, address@hidden wrote:
> No-op MEMOP_SIZE and SIZE_MEMOP macros allows us to later easily
> convert memory_region_dispatch_{read|write} paramter "unsigned size"
> into a size+sign+endianness encoded "MemOp op".
>
> Being a no-op macro, this patch does not introduce any logical change.
>
The last sentence has a bad structure. Possible remedy:
"Being a no-op macro," -> "Relying no-op macros,"
I think this patch should be reogranized (possibly by splitting) so that
the hunks that introduce usage of macros are in a separate patch, which
would leave only changes that directly involve using "MemOp" in this
patch.
Thanks,
Aleksandar
- Re: [Qemu-devel] [PATCH v5 05/15] hw/intc/armv7m_nic: Access MemoryRegion with MemOp, (continued)
- [Qemu-devel] [PATCH v5 06/15] hw/virtio: Access MemoryRegion with MemOp, tony.nguyen, 2019/07/26
- [Qemu-devel] [PATCH v5 07/15] hw/vfio: Access MemoryRegion with MemOp, tony.nguyen, 2019/07/26
- [Qemu-devel] [PATCH v5 08/15] exec: Access MemoryRegion with MemOp, tony.nguyen, 2019/07/26
- [Qemu-devel] [PATCH v5 09/15] cputlb: Access MemoryRegion with MemOp, tony.nguyen, 2019/07/26
- [Qemu-devel] [PATCH v5 10/15] memory: Access MemoryRegion with MemOp semantics, tony.nguyen, 2019/07/26
- [Qemu-devel] [PATCH v5 12/15] cpu: TLB_FLAGS_MASK bit to force memory slow path, tony.nguyen, 2019/07/26
- [Qemu-devel] [PATCH v5 11/15] memory: Single byte swap along the I/O path, tony.nguyen, 2019/07/26