[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] 9p: simplify source file selection
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH] 9p: simplify source file selection |
|
Date: |
Thu, 25 Jul 2019 13:22:53 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 7/25/19 12:29 PM, Paolo Bonzini wrote:
> On 25/07/19 12:21, Peter Maydell wrote:
>
>> Patch definitely looks like a good idea, though -- those
>> nested land/lor calls are pretty ugly :-)
>
> Yeah, FWIW this patch came out of Meson conversion, where the sourceset
> mechanism supports "and", "nand" and "or" very well but has issues with
> "nor". While I'm open to adding "nor" if it is really needed, it seems
> to me that in general we should not transpose our Make mess to Meson,
> and rely on Kconfig as the better tool for this kind of job.
Agreed, good idea.