qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [for 4.2 PATCH v2 0/4] Remove time reset notifications


From: Dr. David Alan Gilbert (git)
Subject: [Qemu-devel] [for 4.2 PATCH v2 0/4] Remove time reset notifications
Date: Wed, 24 Jul 2019 12:58:19 +0100

From: "Dr. David Alan Gilbert" <address@hidden>

Timers have a mechanism for detecting host clock jumps; this relied
on noticing if the time had gone backwards or if it had gone forward
more than 60s since we last read it.  This had assumed that we regularly
read the time, which isn't true any more - we might not read the host
timer until the guest explicitly reads the guest RTC (e.g. hwclock).
This falsely triggers the reset mechanism.
 
The reset mechanism was only used by the mc146818 (i.e. PC) RTC
anyway; so lets remove it.

v2
  Remove the host_clock_last field in replay as per Pavel's review

Dr. David Alan Gilbert (4):
  mc146818rtc: Remove reset notifiers
  timer: Remove reset notifiers
  replay: Remove host_clock_last
  timer: last, remove last bits of last

 hw/timer/mc146818rtc.c   | 19 -------------------
 include/qemu/timer.h     | 35 ----------------------------------
 replay/replay-snapshot.c |  7 ++-----
 util/qemu-timer.c        | 41 +---------------------------------------
 4 files changed, 3 insertions(+), 99 deletions(-)

-- 
2.21.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]