Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls

[Li Qiang]

Stefan Hajnoczi <address@hidden> 于2019年7月23日周二 下午9:03写道：

> On Tue, Jul 23, 2019 at 04:17:54PM +0530, P J P wrote:
> > -            snprintf(helper_cmd, sizeof(helper_cmd), "%s %s %s %s",
> > -                     helper, "--use-vnet", fd_buf, br_buf);
> > +            helper_cmd = g_strdup_printf("%s %s %s %s", helper,
> > +                            "--use-vnet", fd_buf, br_buf ? br_buf : "");
>
> The change to the br_buf argument isn't covered in the commit
> description.  Why did you change this, was it a bug, etc?
>


IIUC, if we pass the NULL argument in g_strdup_printf, the 'helper_cmd'
will contain the '(null)' char.
If we pass "" to g_strdup_printf, there is nothing in 'helper_cmd'. The
original is like this.
So here Prasad has to check the 'fd_buf'.

So:

Reviewed-by: Li Qiang <address@hidden>


Thanks,
Li Qiang