Re: [Qemu-devel] make vm-build-openbsd (was: Re: [PATCH v2 22/23] tests: Run the iotests during "make check" again)

[Thomas Huth]

On 23/07/2019 09.20, Thomas Huth wrote:
> On 22/07/2019 21.53, Philippe Mathieu-Daudé wrote:
> [...]
>> Since Gerd updated the OpenBSD image, do you know if we can run vm-test
>> again?
> 
> I just tried it, but the OpenBSD build seems to be completely broken right 
> now:
> 
> $ nice make vm-build-openbsd 
>     VM-IMAGE openbsd 
> ### Downloading install iso ...
> --2019-07-23 08:52:46--  
> https://cdn.openbsd.org/pub/OpenBSD/6.5/amd64/install65.iso
> Resolving cdn.openbsd.org (cdn.openbsd.org)... 151.101.38.217
> Connecting to cdn.openbsd.org (cdn.openbsd.org)|151.101.38.217|:443... 
> connected.
> HTTP request sent, awaiting response... 200 OK
> Length: 407169024 (388M) [application/octet-stream]
> Saving to: 
> ‘/home/thuth/.cache/qemu-vm/download/54ac74c2128d6c2d3ede38756576fe89c08476bd.download’
> 
> 100%[=======================================================================>]
>  407.169.024 8,55MB/s   in 39s    
> 
> 2019-07-23 08:53:25 (9,98 MB/s) - 
> ‘/home/thuth/.cache/qemu-vm/download/54ac74c2128d6c2d3ede38756576fe89c08476bd.download’
>  saved [407169024/407169024]
> 
> ### Preparing iso and disk image ...
> Formatting '/home/thuth/.cache/qemu-vm/images/openbsd.img.tmp', fmt=qcow2 
> size=21474836480 cluster_size=65536 lazy_refcounts=off refcount_bits=16
> ### Booting installer ...
> console: *** read timeout ***
> console: waiting for: 'timezone'
> console: line buffer:
> 
> con recv: Which disk is the root disk? ('?' for details) [sd0]
> 
> Failed to prepare guest environment
> Traceback (most recent call last):
>   File "/home/thuth/devel/qemu/tests/vm/basevm.py", line 353, in main
>     return vm.build_image(args.image)
>   File "/home/thuth/devel/qemu/tests/vm/openbsd", line 118, in build_image
>     self.console_wait_send("timezone",                "UTC\n")
>   File "/home/thuth/devel/qemu/tests/vm/basevm.py", line 253, in 
> console_wait_send
>     self.console_wait(wait)
>   File "/home/thuth/devel/qemu/tests/vm/basevm.py", line 215, in console_wait
>     chars = vm.console_socket.recv(1)
> socket.timeout: timed out
> make: *** [/home/thuth/.cache/qemu-vm/images/openbsd.img] Error 2
> 
> I even tried to delete the ~/.cache/qemu-vm folder, but that also did
> not help, I'm always getting that time-out now. Does it still work for
> you?

FWIW, it works again with this hack:

diff a/tests/vm/openbsd b/tests/vm/openbsd
--- a/tests/vm/openbsd
+++ b/tests/vm/openbsd
@@ -115,7 +115,7 @@ class OpenBSDVM(basevm.BaseVM):
         self.console_send("%s\n" % self.GUEST_PASS)

         self.console_wait_send("Allow root ssh login",    "yes\n")
-        self.console_wait_send("timezone",                "UTC\n")
+        self.console_send("UTC\n")
         self.console_wait_send("root disk",               "\n")
         self.console_wait_send("(W)hole disk",            "\n")
         self.console_wait_send("(A)uto layout",           "\n")

¯\_(ツ)_/¯

 Thomas