Re: [Qemu-devel] [PATCH for-4.2 03/24] target/arm: Install ASIDs for long-form from EL1

[Richard Henderson]

On 7/22/19 8:28 AM, Alex Bennée wrote:
>> -static void vmsa_ttbr_write(CPUARMState *env, const ARMCPRegInfo *ri,
>> -                            uint64_t value)
>> +static void vmsa_ttbr_el1_write(CPUARMState *env, const ARMCPRegInfo *ri,
>> +                                uint64_t value)
> 
> Why the rename here? It would make sense if it was only EL1 writes but
> the lpae_cp_reginfo doesn't seem to use that nomclature (unless we
> should fix .name for those as well?).

Because in a later patch we'll add vmsa_ttbr_el2_write.

The lpae_cp_reginfo naming is tied to the old aa32 naming,
which isn't as helpful as it might be for aa64.  But the
naming affects migration, iirc, so it can't be changed.


r~