[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] i386/kvm: Do not sync nested state during runti
|
From: |
Jan Kiszka |
|
Subject: |
Re: [Qemu-devel] [PATCH] i386/kvm: Do not sync nested state during runtime |
|
Date: |
Mon, 22 Jul 2019 12:20:31 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 22.07.19 11:44, Liran Alon wrote:
>
>
>> On 22 Jul 2019, at 7:00, Jan Kiszka <address@hidden> wrote:
>>
>> Writing the nested state e.g. after a vmport access can invalidate
>> important parts of the kernel-internal state, and it is not needed as
>> well. So leave this out from KVM_PUT_RUNTIME_STATE.
>>
>> Suggested-by: Paolo Bonzini <address@hidden>
>> Signed-off-by: Jan Kiszka <address@hidden>
>
> As QEMU never modifies vCPU nested-state in userspace besides in vmload and
> vCPU creation,
> shouldn’t this be under KVM_PUT_FULL_STATE? Same as the call to
> kvm_arch_set_tsc_khz().
Reset is a relevant modification as well. If we do not write back a state that
is disabling virtualization, we break.
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux