Re: [Qemu-devel] [PATCH] migration: use migration_in_postcopy() to check POSTCOPY_ACTIVE

[Dr. David Alan Gilbert]

* Wei Yang (address@hidden) wrote:
> Use common helper function to check the state.
> 
> Signed-off-by: Wei Yang <address@hidden>

Reviewed-by: Dr. David Alan Gilbert <address@hidden>

> ---
>  migration/rdma.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/migration/rdma.c b/migration/rdma.c
> index 3036221ee8..0e73e759ca 100644
> --- a/migration/rdma.c
> +++ b/migration/rdma.c
> @@ -3140,7 +3140,7 @@ static size_t qemu_rdma_save_page(QEMUFile *f, void 
> *opaque,
>  
>      CHECK_ERROR_STATE();
>  
> -    if (migrate_get_current()->state == MIGRATION_STATUS_POSTCOPY_ACTIVE) {
> +    if (migration_in_postcopy()) {
>          rcu_read_unlock();
>          return RAM_SAVE_CONTROL_NOT_SUPP;
>      }
> @@ -3775,7 +3775,7 @@ static int qemu_rdma_registration_start(QEMUFile *f, 
> void *opaque,
>  
>      CHECK_ERROR_STATE();
>  
> -    if (migrate_get_current()->state == MIGRATION_STATUS_POSTCOPY_ACTIVE) {
> +    if (migration_in_postcopy()) {
>          rcu_read_unlock();
>          return 0;
>      }
> @@ -3810,7 +3810,7 @@ static int qemu_rdma_registration_stop(QEMUFile *f, 
> void *opaque,
>  
>      CHECK_ERROR_STATE();
>  
> -    if (migrate_get_current()->state == MIGRATION_STATUS_POSTCOPY_ACTIVE) {
> +    if (migration_in_postcopy()) {
>          rcu_read_unlock();
>          return 0;
>      }
> -- 
> 2.17.1
> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK