[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 02/14] qapi/block-core: add option for io_uri
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 02/14] qapi/block-core: add option for io_uring |
Date: |
Fri, 19 Jul 2019 10:49:30 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 7/19/19 8:35 AM, Aarushi Mehta wrote:
> Only enumerates option for devices that support it
>
> Signed-off-by: Aarushi Mehta <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> ---
> qapi/block-core.json | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 0d43d4f37c..0a3d4ae7d2 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2792,11 +2792,13 @@
> #
> # @threads: Use qemu's thread pool
> # @native: Use native AIO backend (only Linux and Windows)
> +# @io_uring: Use linux io_uring (since 4.1)
I know you explained in an earlier revision why you chose 'io_uring'
instead of the more typical QAPI spelling of 'io-uring' (namely, it
matches the Linux kernel feature spelling). That explanation belongs in
the commit message, rather than just the mailing list archives.
> #
> # Since: 2.9
> ##
> { 'enum': 'BlockdevAioOptions',
> - 'data': [ 'threads', 'native' ] }
> + 'data': [ 'threads', 'native',
> + { 'name': 'io_uring', 'if': 'defined(CONFIG_LINUX_IO_URING)' } ]
> }
>
> ##
> # @BlockdevCacheOptions:
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v6 00/14] Add support for io_uring, Aarushi Mehta, 2019/07/19
- [Qemu-devel] [PATCH v6 00/14] Add support for io_uring, Aarushi Mehta, 2019/07/19
- [Qemu-devel] [PATCH v6 01/14] configure: permit use of io_uring, Aarushi Mehta, 2019/07/19
- [Qemu-devel] [PATCH v6 02/14] qapi/block-core: add option for io_uring, Aarushi Mehta, 2019/07/19
- [Qemu-devel] [PATCH v6 03/14] block/block: add BDRV flag for io_uring, Aarushi Mehta, 2019/07/19
- [Qemu-devel] [PATCH v6 04/14] block/io_uring: implements interfaces for io_uring, Aarushi Mehta, 2019/07/19
- [Qemu-devel] [PATCH v6 05/14] stubs: add stubs for io_uring interface, Aarushi Mehta, 2019/07/19
- [Qemu-devel] [PATCH v6 06/14] util/async: add aio interfaces for io_uring, Aarushi Mehta, 2019/07/19
- [Qemu-devel] [PATCH v6 07/14] blockdev: accept io_uring as option, Aarushi Mehta, 2019/07/19
- [Qemu-devel] [PATCH v6 08/14] block/file-posix.c: extend to use io_uring, Aarushi Mehta, 2019/07/19
- [Qemu-devel] [PATCH v6 09/14] block: add trace events for io_uring, Aarushi Mehta, 2019/07/19