Re: [Qemu-devel] [PATCH v6 11/14] qemu-io: adds option to use aio engine

[Daniel P . Berrangé]

On Fri, Jul 19, 2019 at 04:41:15PM +0100, Stefan Hajnoczi wrote:
> On Fri, Jul 19, 2019 at 07:05:27PM +0530, Aarushi Mehta wrote:
> > Use -i AIOMODE instead of -k.
> > 
> > Signed-off-by: Aarushi Mehta <address@hidden>
> > ---
> >  qemu-io.c | 25 ++++++++++++++++---------
> >  1 file changed, 16 insertions(+), 9 deletions(-)
> > 
> > diff --git a/qemu-io.c b/qemu-io.c
> > index f64eca6940..3cee06248e 100644
> > --- a/qemu-io.c
> > +++ b/qemu-io.c
> > @@ -130,7 +130,7 @@ static void open_help(void)
> >  " -C, -- use copy-on-read\n"
> >  " -n, -- disable host cache, short for -t none\n"
> >  " -U, -- force shared permissions\n"
> > -" -k, -- use kernel AIO implementation (on Linux only)\n"
> > +" -i, -- use AIO mode (threads, native or io_uring)"
> 
> Please keep the existing option for backwards compatibility.  Existing
> command-lines must continue to work so we don't inconvenience users.

We could deprecate the -k option though, so it can be deleted a couple
of releases later.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|