Re: [Qemu-devel] [PATCH v1 00/23] s390x/tcg: Vector Instruction Support Part 4

[Aleksandar Markovic]

On May 31, 2019 12:48 PM, "David Hildenbrand" <address@hidden> wrote:
>
> This is the final part of vector instruction support for s390x. It is
based
> on part 2, which is will send a pull-request for to Conny soon.
>
> Part 1: Vector Support Instructions
> Part 2: Vector Integer Instructions
> Part 3: Vector String Instructions
> Part 4: Vector Floating-Point Instructions
>

Congratulations on completing this complex task!

I followed your series (even though I did not make any comment), and I
salute this addition to QEMU.

I would just ask you to provide me and others with the link to the detailed
documentation on this matter - I had the hardest time trying to find it
online.

Thanks in advance!

Aleksandar

> The current state can be found at (kept updated):
>     https://github.com/davidhildenbrand/qemu/tree/vx
>
> It is based on:
> - [PATCH v2 0/5] s390x/tcg: Vector Instruction Support Part 3
> - [PATCH v1 0/2] s390x: Fix vector register alignment
>
> With the current state I can boot Linux kernel + user space compiled with
> SIMD support. This allows to boot distributions compiled exclusively for
> z13, requiring SIMD support. Also, it is now possible to build a complete
> kernel using rpmbuild as quite some issues have been sorted out.
>
> While the current state works fine for me with RHEL 8, I am experiencing
> some issues with newer userspace versions (I suspect glibc). I'll have
> to look into the details first - could be a BUG in !vector
> instruction or a BUG in a vector instruction that was until now unused.
>
> In this part, all Vector Floating-Point Instructions introduced with the
> "Vector Facility" are added. Also, the "qemu" model is changed to a
> z13 machine.
>
> David Hildenbrand (23):
>   s390x: Use uint64_t for vector registers
>   s390x/tcg: Introduce tcg_s390_vector_exception()
>   s390x/tcg: Export float_comp_to_cc() and float(32|64|128)_dcmask()
>   s390x/tcg: Implement VECTOR FP ADD
>   s390x/tcg: Implement VECTOR FP COMPARE (AND SIGNAL) SCALAR
>   s390x/tcg: Implement VECTOR FP COMPARE (EQUAL|HIGH|HIGH OR EQUAL)
>   s390x/tcg: Implement VECTOR FP CONVERT FROM FIXED 64-BIT
>   s390x/tcg: Implement VECTOR FP CONVERT FROM LOGICAL 64-BIT
>   s390x/tcg: Implement VECTOR FP CONVERT TO FIXED 64-BIT
>   s390x/tcg: Implement VECTOR FP CONVERT TO LOGICAL 64-BIT
>   s390x/tcg: Implement VECTOR FP DIVIDE
>   s390x/tcg: Implement VECTOR LOAD FP INTEGER
>   s390x/tcg: Implement VECTOR LOAD LENGTHENED
>   s390x/tcg: Implement VECTOR LOAD ROUNDED
>   s390x/tcg: Implement VECTOR FP MULTIPLY
>   s390x/tcg: Implement VECTOR FP MULTIPLY AND (ADD|SUBTRACT)
>   s390x/tcg: Implement VECTOR FP PERFORM SIGN OPERATION
>   s390x/tcg: Implement VECTOR FP SQUARE ROOT
>   s390x/tcg: Implement VECTOR FP SUBTRACT
>   s390x/tcg: Implement VECTOR FP TEST DATA CLASS IMMEDIATE
>   s390x/tcg: Allow linux-user to use vector instructions
>   s390x/tcg: We support the Vector Facility
>   s390x: Bump the "qemu" CPU model up to a stripped-down z13
>
>  hw/s390x/s390-virtio-ccw.c      |   2 +
>  linux-user/s390x/signal.c       |   4 +-
>  target/s390x/Makefile.objs      |   1 +
>  target/s390x/arch_dump.c        |   8 +-
>  target/s390x/cpu.c              |   3 +
>  target/s390x/cpu.h              |   5 +-
>  target/s390x/cpu_models.c       |   4 +-
>  target/s390x/excp_helper.c      |  21 +-
>  target/s390x/fpu_helper.c       |   4 +-
>  target/s390x/gdbstub.c          |  16 +-
>  target/s390x/gen-features.c     |  10 +-
>  target/s390x/helper.c           |  10 +-
>  target/s390x/helper.h           |  46 +++
>  target/s390x/insn-data.def      |  45 +++
>  target/s390x/internal.h         |   4 +
>  target/s390x/kvm.c              |  16 +-
>  target/s390x/machine.c          | 128 +++----
>  target/s390x/tcg_s390x.h        |   2 +
>  target/s390x/translate.c        |   2 +-
>  target/s390x/translate_vx.inc.c | 274 ++++++++++++++
>  target/s390x/vec_fpu_helper.c   | 644 ++++++++++++++++++++++++++++++++
>  21 files changed, 1145 insertions(+), 104 deletions(-)
>  create mode 100644 target/s390x/vec_fpu_helper.c
>
> --
> 2.20.1
>
>