[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] pc: fix possible NULL pointer dereference in
Michael S. Tsirkin
Re: [Qemu-devel] [PATCH v2] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size()
Wed, 17 Jul 2019 07:24:14 -0400
On Wed, Jul 17, 2019 at 01:22:27PM +0200, Paolo Bonzini wrote:
> On 17/07/19 12:37, Michael S. Tsirkin wrote:
> > On Mon, Jun 24, 2019 at 05:02:00AM -0400, Igor Mammedov wrote:
> >> QEMU will crash when device-memory-region-size property is read if
> >> ms->device_memory
> >> wasn't initialized yet.
> >> Crash can be reproduced with:
> >> $QEMU -preconfig -qmp unix:qmp_socket,server,nowait &
> >> ./scripts/qmp/qom-get -s qmp_socket /machine.device-memory-region-size
> >> Instead of crashing return 0 if ms->device_memory hasn't been initialized.
> >> Signed-off-by: Igor Mammedov <address@hidden>
> > queued, thanks!
> This is already commit 58164eaff530a1e804f5710936dd37518ab5a90e.
In fact yes, git am just silently ignores a patch.
Donnu why did it not get dropped from the review inbox, weird.