[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH for 4.1] linux-user: unparent CPU object before
From: |
Alex Bennée |
Subject: |
[Qemu-devel] [RFC PATCH for 4.1] linux-user: unparent CPU object before unref |
Date: |
Tue, 16 Jul 2019 15:01:33 +0100 |
When a CPU object is created it is parented during it's realize stage.
If we don't unparent before the "final" unref we will never finzalize
the object leading to a memory leak. For most setups you probably
won't notice but with anything that creates and destroys a lot of
threads this will add up. This goes especially for architectures which
allocate a lot of memory in their CPU structures.
Fixes: https://bugs.launchpad.net/qemu/+bug/1836558
Cc: address@hidden
Signed-off-by: Alex Bennée <address@hidden>
---
linux-user/syscall.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 39a37496fed..4c9313fd9d0 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -7183,6 +7183,7 @@ static abi_long do_syscall1(void *cpu_env, int num,
abi_long arg1,
NULL, NULL, 0);
}
thread_cpu = NULL;
+ object_unparent(OBJECT(cpu));
object_unref(OBJECT(cpu));
g_free(ts);
rcu_unregister_thread();
--
2.20.1
- [Qemu-devel] [RFC PATCH for 4.1] linux-user: unparent CPU object before unref,
Alex Bennée <=