[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 13/21] kvm: Update comments for sync_dirty_bitmap
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PULL 13/21] kvm: Update comments for sync_dirty_bitmap |
Date: |
Mon, 15 Jul 2019 15:51:17 +0200 |
From: Peter Xu <address@hidden>
It's obviously obsolete. Do some update.
Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>
---
accel/kvm/kvm-all.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index 3d86ae5052..a3df19da56 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -478,13 +478,13 @@ static int
kvm_get_dirty_pages_log_range(MemoryRegionSection *section,
#define ALIGN(x, y) (((x)+(y)-1) & ~((y)-1))
/**
- * kvm_physical_sync_dirty_bitmap - Grab dirty bitmap from kernel space
- * This function updates qemu's dirty bitmap using
- * memory_region_set_dirty(). This means all bits are set
- * to dirty.
+ * kvm_physical_sync_dirty_bitmap - Sync dirty bitmap from kernel space
*
- * @start_add: start of logged region.
- * @end_addr: end of logged region.
+ * This function will first try to fetch dirty bitmap from the kernel,
+ * and then updates qemu's dirty bitmap.
+ *
+ * @kml: the KVM memory listener object
+ * @section: the memory section to sync the dirty bitmap with
*/
static int kvm_physical_sync_dirty_bitmap(KVMMemoryListener *kml,
MemoryRegionSection *section)
--
2.21.0
- [Qemu-devel] [PULL 03/21] migration/multifd: call multifd_send_sync_main when sending RAM_SAVE_FLAG_EOS, (continued)
- [Qemu-devel] [PULL 03/21] migration/multifd: call multifd_send_sync_main when sending RAM_SAVE_FLAG_EOS, Juan Quintela, 2019/07/15
- [Qemu-devel] [PULL 04/21] migration/xbzrle: update cache and current_data in one place, Juan Quintela, 2019/07/15
- [Qemu-devel] [PULL 05/21] cutils: remove one unnecessary pointer operation, Juan Quintela, 2019/07/15
- [Qemu-devel] [PULL 06/21] migration/multifd: sync packet_num after all thread are done, Juan Quintela, 2019/07/15
- [Qemu-devel] [PULL 07/21] migration/ram.c: reset complete_round when we gets a queued page, Juan Quintela, 2019/07/15
- [Qemu-devel] [PULL 08/21] migration: No need to take rcu during sync_dirty_bitmap, Juan Quintela, 2019/07/15
- [Qemu-devel] [PULL 09/21] memory: Don't set migration bitmap when without migration, Juan Quintela, 2019/07/15
- [Qemu-devel] [PULL 10/21] bitmap: Add bitmap_copy_with_{src|dst}_offset(), Juan Quintela, 2019/07/15
- [Qemu-devel] [PULL 11/21] memory: Pass mr into snapshot_and_clear_dirty, Juan Quintela, 2019/07/15
- [Qemu-devel] [PULL 12/21] memory: Introduce memory listener hook log_clear(), Juan Quintela, 2019/07/15
- [Qemu-devel] [PULL 13/21] kvm: Update comments for sync_dirty_bitmap,
Juan Quintela <=
- [Qemu-devel] [PULL 14/21] kvm: Persistent per kvmslot dirty bitmap, Juan Quintela, 2019/07/15
- [Qemu-devel] [PULL 15/21] kvm: Introduce slots lock for memory listener, Juan Quintela, 2019/07/15
- [Qemu-devel] [PULL 16/21] kvm: Support KVM_CLEAR_DIRTY_LOG, Juan Quintela, 2019/07/15
- [Qemu-devel] [PULL 17/21] migration: Split log_clear() into smaller chunks, Juan Quintela, 2019/07/15
- [Qemu-devel] [PULL 18/21] migration: allow private destination ram with x-ignore-shared, Juan Quintela, 2019/07/15
- [Qemu-devel] [PULL 19/21] migration/postcopy: fix document of postcopy_send_discard_bm_ram(), Juan Quintela, 2019/07/15
- [Qemu-devel] [PULL 20/21] migration/postcopy: remove redundant cpu_synchronize_all_post_init, Juan Quintela, 2019/07/15
- [Qemu-devel] [PULL 21/21] migration: always initial RAMBlock.bmap to 1 for new migration, Juan Quintela, 2019/07/15
- Re: [Qemu-devel] [PULL 00/21] Migration pull request, Peter Maydell, 2019/07/15