[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/12] block: Fixes for concurrent block jobs
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/12] block: Fixes for concurrent block jobs |
Date: |
Mon, 15 Jul 2019 15:41:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 |
On 03.07.19 19:28, Max Reitz wrote:
> This is a v2 to “block: Add BDS.never_freeze”.
>
> It depends on my “block: Delay poll when ending drained sections”
> series:
>
> Depends-on: <address@hidden>
>
>
> It turned out that if you run 030 (or just the new test_overlapping_5
> case) sufficiently often, it breaks; which is why I’m hesitant to just
> merge the “add never_freeze” series as it is.
>
> There are several reasons for why this test case breaks, I hope patches
> 3 to 6 fix them. Patch 12 adds a test that is much more reliable than
> test_overlapping_5 at detecting the problems fixed by at least patches 4
> to 6. (I think that 3 doesn’t really need a test.)
>
> I’m sure there are other ways to see these problems, but well, coming
> from 030, concurrent commit/stream jobs are how I reproduced them.
> Hence the same of this series.
>
> Patch 2 is for something I encountered on the way. Patch 11 tests it.
Applied patches 1, 2, 3, and 6 through 11 to my block branch.
So what remains are patches 4, 5, and 12.
For 4, I don’t know whether the approach is too heavy-handed (maybe a
simple bdrv_drained_begin()/-end() would suffice), and whether it’s even
right to wrap the whole function in a drained section. (Unless there
are objections, I’ll still take it for rc2.)
5 is just pretty complex, and it also depends on my other series in its
current form. So I wouldn’t like to take it without any reviews.
12 is a test that will fail without 4 and 5, so I can’t take it without
those two.
Max
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 02/12] block/stream: Fix error path, (continued)
- [Qemu-devel] [PATCH v2 02/12] block/stream: Fix error path, Max Reitz, 2019/07/03
- [Qemu-devel] [PATCH v2 05/12] block: Reduce (un)drains when replacing a child, Max Reitz, 2019/07/03
- [Qemu-devel] [PATCH v2 09/12] iotests: Add @use_log to VM.run_job(), Max Reitz, 2019/07/03
- [Qemu-devel] [PATCH v2 12/12] iotests: Add test for concurrent stream/commit, Max Reitz, 2019/07/03
- [Qemu-devel] [PATCH v2 07/12] iotests: Fix throttling in 030, Max Reitz, 2019/07/03
- [Qemu-devel] [PATCH v2 03/12] block/stream: Swap backing file change order, Max Reitz, 2019/07/03
- [Qemu-devel] [PATCH v2 08/12] iotests: Compare error messages in 030, Max Reitz, 2019/07/03
- [Qemu-devel] [PATCH v2 06/12] block: Deep-clear inherits_from, Max Reitz, 2019/07/03
- [Qemu-devel] [PATCH v2 10/12] iotests: Add new case to 030, Max Reitz, 2019/07/03
- Re: [Qemu-devel] [PATCH v2 00/12] block: Fixes for concurrent block jobs, Max Reitz, 2019/07/10
- Re: [Qemu-devel] [PATCH v2 00/12] block: Fixes for concurrent block jobs,
Max Reitz <=