[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 08/19] migration/ram.c: reset complete_round when we
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PULL 08/19] migration/ram.c: reset complete_round when we gets a queued page |
Date: |
Fri, 12 Jul 2019 16:31:56 +0200 |
From: Wei Yang <address@hidden>
In case we gets a queued page, the order of block is interrupted. We may
not rely on the complete_round flag to say we have already searched the
whole blocks on the list.
Signed-off-by: Wei Yang <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>
---
migration/ram.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/migration/ram.c b/migration/ram.c
index 96c84f770a..89eec7ee9d 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -2286,6 +2286,12 @@ static bool get_queued_page(RAMState *rs,
PageSearchStatus *pss)
*/
pss->block = block;
pss->page = offset >> TARGET_PAGE_BITS;
+
+ /*
+ * This unqueued page would break the "one round" check, even is
+ * really rare.
+ */
+ pss->complete_round = false;
}
return !!block;
--
2.21.0
- Re: [Qemu-devel] [PULL 00/19] Migration patches, (continued)
- Re: [Qemu-devel] [PULL 00/19] Migration patches, no-reply, 2019/07/12
- [Qemu-devel] [PULL 00/19] Migration patches, Juan Quintela, 2019/07/12
- [Qemu-devel] [PULL 01/19] migration: fix multifd_recv event typo, Juan Quintela, 2019/07/12
- [Qemu-devel] [PULL 02/19] migration-test: rename parameter to parameter_int, Juan Quintela, 2019/07/12
- [Qemu-devel] [PULL 03/19] migration-test: Add migration multifd test, Juan Quintela, 2019/07/12
- [Qemu-devel] [PULL 05/19] migration/xbzrle: update cache and current_data in one place, Juan Quintela, 2019/07/12
- [Qemu-devel] [PULL 06/19] cutils: remove one unnecessary pointer operation, Juan Quintela, 2019/07/12
- [Qemu-devel] [PULL 04/19] migration/multifd: call multifd_send_sync_main when sending RAM_SAVE_FLAG_EOS, Juan Quintela, 2019/07/12
- [Qemu-devel] [PULL 07/19] migration/multifd: sync packet_num after all thread are done, Juan Quintela, 2019/07/12
- [Qemu-devel] [PULL 09/19] migration: No need to take rcu during sync_dirty_bitmap, Juan Quintela, 2019/07/12
- [Qemu-devel] [PULL 08/19] migration/ram.c: reset complete_round when we gets a queued page,
Juan Quintela <=
- [Qemu-devel] [PULL 10/19] memory: Don't set migration bitmap when without migration, Juan Quintela, 2019/07/12
- [Qemu-devel] [PULL 11/19] bitmap: Add bitmap_copy_with_{src|dst}_offset(), Juan Quintela, 2019/07/12
- [Qemu-devel] [PULL 12/19] memory: Pass mr into snapshot_and_clear_dirty, Juan Quintela, 2019/07/12
- [Qemu-devel] [PULL 13/19] memory: Introduce memory listener hook log_clear(), Juan Quintela, 2019/07/12
- [Qemu-devel] [PULL 14/19] kvm: Update comments for sync_dirty_bitmap, Juan Quintela, 2019/07/12
- [Qemu-devel] [PULL 15/19] kvm: Persistent per kvmslot dirty bitmap, Juan Quintela, 2019/07/12
- [Qemu-devel] [PULL 16/19] kvm: Introduce slots lock for memory listener, Juan Quintela, 2019/07/12
- [Qemu-devel] [PULL 17/19] kvm: Support KVM_CLEAR_DIRTY_LOG, Juan Quintela, 2019/07/12
- [Qemu-devel] [PULL 18/19] migration: Split log_clear() into smaller chunks, Juan Quintela, 2019/07/12
- [Qemu-devel] [PULL 19/19] migration: allow private destination ram with x-ignore-shared, Juan Quintela, 2019/07/12