[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH-for-4.1 2/7] hw/usb: Bluetooth HCI USB depends o
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH-for-4.1 2/7] hw/usb: Bluetooth HCI USB depends on USB & BLUETOOTH |
|
Date: |
Fri, 12 Jul 2019 16:16:57 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 7/12/19 3:58 PM, Paolo Bonzini wrote:
> On 12/07/19 15:39, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>> hw/usb/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
>> index 564305e283..1b435ec002 100644
>> --- a/hw/usb/Kconfig
>> +++ b/hw/usb/Kconfig
>> @@ -82,7 +82,7 @@ config USB_NETWORK
>> config USB_BLUETOOTH
>> bool
>> default y
>> - depends on USB
>> + depends on USB && BLUETOOTH
>>
>> config USB_SMARTCARD
>> bool
>>
>
> Shouldn't it select BLUETOOTH instead?
I wondered but am not sure, it is default to Yes, but Bluetooth code is
deprecated and print a big warning when you use it, so I think this
device should not be selected as default, neither pull in the deprecated
bluetooth code.
So personally I'd respin without 'default y'. If you have a good reason
to use it, I can use 'select' instead.
Regards,
Phil.
[Qemu-devel] [PATCH-for-4.1? 3/7] MAINTAINERS: Add an entry for the Bluetooth devices, Philippe Mathieu-Daudé, 2019/07/12
[Qemu-devel] [PATCH-for-4.1? 4/7] vl: Fix 'braces' coding style issues, Philippe Mathieu-Daudé, 2019/07/12
[Qemu-devel] [PATCH-for-4.1? 5/7] vl: Use qemu_strtoi() instead of strtol(), Philippe Mathieu-Daudé, 2019/07/12
[Qemu-devel] [PATCH-for-4.1? 6/7] vl: Extract bt_parse() into its own file, Philippe Mathieu-Daudé, 2019/07/12
[Qemu-devel] [PATCH-for-4.1? 7/7] hw/bt: Allow building with CONFIG_BLUETOOTH disabled, Philippe Mathieu-Daudé, 2019/07/12