[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/5] tests/docker: add podman support
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/5] tests/docker: add podman support |
Date: |
Thu, 11 Jul 2019 16:55:20 +0100 |
User-agent: |
mu4e 1.3.2; emacs 26.1 |
Paolo Bonzini <address@hidden> writes:
> On 10/07/19 10:39, Marc-André Lureau wrote:
>>> Why not do this in docker.py (either as part of patch 1 or separately)?
>>> Also, can you document in a comment why this is not needed with docker?
>>
>> Doing it in docker.py would probably mean parsing and tweaking
>> arguments given to Docker.run(). Since it's a "temporary" work around,
>> I would rather have it at the top-level caller, in the Makefile.
>
> On the other hand that splits the choice of docker vs. podman in two
> places, and Python is a better place to implement workarounds.
Yeah I agree we should move this trickery away from the Makefiles.
--
Alex Bennée
- [Qemu-devel] [PATCH v2 3/5] tests: specify the address family when checking bind, (continued)
- [Qemu-devel] [PATCH v2 3/5] tests: specify the address family when checking bind, Marc-André Lureau, 2019/07/09
- [Qemu-devel] [PATCH v2 5/5] test: skip tests if socket_check_protocol_support() failed, Marc-André Lureau, 2019/07/09
- [Qemu-devel] [PATCH v2 4/5] test-char: skip tcp tests if ipv4 check failed, Marc-André Lureau, 2019/07/09
- [Qemu-devel] [PATCH v2 1/5] docker.py: add podman support, Marc-André Lureau, 2019/07/09
- [Qemu-devel] [PATCH v2 2/5] tests/docker: add podman support, Marc-André Lureau, 2019/07/09
- Re: [Qemu-devel] [PATCH v2 2/5] tests/docker: add podman support, Debarshi Ray, 2019/07/17
Re: [Qemu-devel] [PATCH v2 0/5] tests/docker: add podman support, no-reply, 2019/07/09