[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] doc: Preallocation does not require writing zer
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH] doc: Preallocation does not require writing zeroes |
Date: |
Thu, 11 Jul 2019 14:42:16 +0100 |
User-agent: |
Mutt/1.12.0 (2019-05-25) |
On Thu, Jul 11, 2019 at 03:29:35PM +0200, Max Reitz wrote:
> When preallocating an encrypted qcow2 image, it just lets the protocol
> driver write data and then does not mark the clusters as zero.
> Therefore, reading this image will yield effectively random data.
>
> As such, we have not fulfilled the promise of always writing zeroes when
> preallocating an image in a while. It seems that nobody has really
> cared, so change the documentation to conform to qemu's actual behavior.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> qapi/block-core.json | 9 +++++----
> docs/qemu-block-drivers.texi | 4 ++--
> qemu-img.texi | 4 ++--
> 3 files changed, 9 insertions(+), 8 deletions(-)
Reviewed-by: Daniel P. Berrangé <address@hidden>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|