[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 3/5] tests/tcg: fix diff-out pass to properly
|
From: |
Alex Bennée |
|
Subject: |
Re: [Qemu-devel] [PATCH v1 3/5] tests/tcg: fix diff-out pass to properly report failure |
|
Date: |
Wed, 10 Jul 2019 09:38:54 +0100 |
|
User-agent: |
mu4e 1.3.2; emacs 26.1 |
Richard Henderson <address@hidden> writes:
> On 7/5/19 6:04 PM, Alex Bennée wrote:
>> +diff-out = $(call quiet-command, diff -q $1.out $2 || \
>> + (diff -u $1.out $2 | head -n 10 && false), \
>
> What about (set -o pipefail; diff ... | head) ?
> I think we already rely on bash, right?
I don't think so - we assume POSIX shell for configure and AFAICT we
don't do anything special in the make system to set the shell type to
bash.
--
Alex Bennée