[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 2/5] tests/tcg: fix up test-i386-fprem.ref ge
Re: [Qemu-devel] [PATCH v1 2/5] tests/tcg: fix up test-i386-fprem.ref generation
Wed, 10 Jul 2019 08:58:41 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1
On 7/5/19 6:04 PM, Alex Bennée wrote:
> We never shipped the reference data in the source tree because it was
> quite big (64M). As a result the only option is to generate it
> locally. Although we have a rule to generate the reference file we
> missed the dependency and location changes, probably because it is
> only run for SLOW test runs.
> The test still fails with mostly incorrect flags and different than
> expected NaNs. I'll leave that for the x86 experts to look at.
> Signed-off-by: Alex Bennée <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Richard Henderson <address@hidden>
> Cc: Eduardo Habkost <address@hidden>
> Cc: Jan Bobek <address@hidden>
> tests/tcg/i386/Makefile.target | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
There's nothing here to guess that test-i386-fprem is in any way natively
runnable. Otherwise you might just end up testing against the installed qemu.
On the other hand, at the moment this simply won't run at all, since the input
file is missing. So I suppose this is good enough for SLOW.
Reviewed-by: Richard Henderson <address@hidden>