[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/11] audio: basic support for multi backend au
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 02/11] audio: basic support for multi backend audio |
Date: |
Wed, 10 Jul 2019 06:06:07 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
"Kővágó, Zoltán" <address@hidden> writes:
> Audio functions no longer access glob_audio_state, instead they get an
> AudioState as a parameter. This is required in order to support
> multiple backends.
>
> glob_audio_state is also gone, and replaced with a tailq so we can store
> more than one states.
>
> Signed-off-by: Kővágó, Zoltán <address@hidden>
> ---
[...]
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index bfa5681dd2..23196da3fe 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -819,16 +819,17 @@ ETEXI
>
> {
> .name = "wavcapture",
> - .args_type = "path:F,freq:i?,bits:i?,nchannels:i?",
> - .params = "path [frequency [bits [channels]]]",
> + .args_type = "path:F,freq:i?,bits:i?,nchannels:i?,audiodev:s?",
> + .params = "path [frequency [bits [channels [audiodev]]]]",
> .help = "capture audio to a wave file (default frequency=44100
> bits=16 channels=2)",
> .cmd = hmp_wavcapture,
> },
> STEXI
> -@item wavcapture @var{filename} [@var{frequency} [@var{bits}
> [@var{channels}]]]
> +@item wavcapture @var{filename} [@var{frequency} [@var{bits} [@var{channels}
> [@var{audiodev}]]]]
> @findex wavcapture
> -Capture audio into @var{filename}. Using sample rate @var{frequency}
> -bits per sample @var{bits} and number of channels @var{channels}.
> +Capture audio into @var{filename} from @var{audiodev}. Using sample rate
> +@var{frequency} bits per sample @var{bits} and number of channels
> +@var{channels}.
>
> Defaults:
> @itemize @minus
@item Sample rate = 44100 Hz - CD quality
@item Bits = 16
@item Number of channels = 2 - Stereo
@end itemize
ETEXI
Defaults for the other optional arguments are listed here. Why not for
@audiodev?
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 9621e934c0..0111055aa4 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1978,6 +1978,11 @@ can help the device and guest to keep up and not lose
> events in case
> events are arriving in bulk. Possible causes for the latter are flaky
> network connections, or scripts for automated testing.
>
> +@item audiodev=@var{audiodev}
> +
> +Use the specified @var{audiodev} when the VNC client requests audio
> +transmission.
> +
What's the default?
> @end table
> ETEXI
- Re: [Qemu-devel] [PATCH 09/11] paaudio: fix playback glitches, (continued)
- [Qemu-devel] [PATCH 05/11] paaudio: do not move stream when sink/source name is specified, Kővágó, Zoltán, 2019/07/09
- [Qemu-devel] [PATCH 03/11] audio: add audiodev properties to frontends, Kővágó, Zoltán, 2019/07/09
- [Qemu-devel] [PATCH 10/11] audio: remove read and write pcm_ops, Kővágó, Zoltán, 2019/07/09
- [Qemu-devel] [PATCH 01/11] audio: reduce glob_audio_state usage, Kővágó, Zoltán, 2019/07/09
- [Qemu-devel] [PATCH 02/11] audio: basic support for multi backend audio, Kővágó, Zoltán, 2019/07/09
- Re: [Qemu-devel] [PATCH 02/11] audio: basic support for multi backend audio,
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH 02/11] audio: basic support for multi backend audio, Marc-André Lureau, 2019/07/10
[Qemu-devel] [PATCH 07/11] audio: remove audio_MIN, audio_MAX, Kővágó, Zoltán, 2019/07/09
[Qemu-devel] [PATCH 04/11] audio: audiodev= parameters no longer optional when -audiodev present, Kővágó, Zoltán, 2019/07/09