[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 1/1] hw/scsi: Report errors and sense to gues
Re: [Qemu-devel] [PATCH v1 1/1] hw/scsi: Report errors and sense to guests through scsi-block
Tue, 9 Jul 2019 08:27:02 +0000
On 7/6/19 2:08 AM, Paolo Bonzini wrote:
> On 05/07/19 12:31, Shinichiro Kawasaki wrote:
>>> This way there's generally no need to shoehorn ASC codes into errno. I
>>> still have to test my changes, but I hope to send something within a
>>> couple of days.
>> Thanks for sharing your thoughts. Now I understand your idea.
>> I'm awaiting your patch. In case you want me to create the patch based on
>> idea, please let me know. I can afford some time next week to work on it.
> I didn't have time to finish, but since I will be out for part of next
> week, here is what I currently have (untested, somewhat uncompiled).
Paolo, thanks for the patch! With a few simple compile error fixes, the patch
series worked with my system as expected. Zoned storage devices are visible on
the guest through scsi-block driver. Good.
Here I list the compile error fixes for your reference:
1) changed return type of scsi_sense_buf_is_guest_recoverable() from int to bool
2) replaced scsi_sense_to_errno() call in scsi_sense_buf_is_guest_recoverable()
3) removed unused "out:" label in block/iscsi.c