Re: [Qemu-devel] [PATCH v3 0/4] m68k: Add basic support for the NeXTcube machine

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH v3 0/4] m68k: Add basic support for the NeXTcube 
machine

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
ef92db6583 m68k: Add an entry for the NeXTcube machine to the MAINTAINERS file
83bed1b09c m68k: Add NeXTcube machine
86ab91916c m68k: Add NeXTcube keyboard device
870bb92660 m68k: Add NeXTcube framebuffer device emulation

=== OUTPUT BEGIN ===
1/4 Checking commit 870bb92660ae (m68k: Add NeXTcube framebuffer device 
emulation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
new file mode 100644

total: 0 errors, 1 warnings, 170 lines checked

Patch 1/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/4 Checking commit 86ab91916cb0 (m68k: Add NeXTcube keyboard device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 293 lines checked

Patch 2/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/4 Checking commit 83bed1b09cef (m68k: Add NeXTcube machine)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

WARNING: Block comments use * on subsequent lines
#118: FILE: hw/m68k/next-cube.c:83:
+/*
+static const uint8_t rtc_ram3[32] = {

ERROR: space required after that ',' (ctx:VxV)
#938: FILE: hw/m68k/next-cube.c:903:
+    memory_region_init_alias(aliasmem, NULL,"next.unknown", mmiomem, 0xc0020,
                                            ^

total: 1 errors, 2 warnings, 1018 lines checked

Patch 3/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/4 Checking commit ef92db658309 (m68k: Add an entry for the NeXTcube machine 
to the MAINTAINERS file)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden