[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC v1 17/18] intel_iommu: propagate PASID-based iotlb flu
From: |
Liu Yi L |
Subject: |
[Qemu-devel] [RFC v1 17/18] intel_iommu: propagate PASID-based iotlb flush to host |
Date: |
Fri, 5 Jul 2019 19:01:50 +0800 |
Intel VT-d 3.0 supports nested translation in PASID granularity. For guest
SVA support, nested translation is enabled for specific PASID. In such case,
guest owns the GVA->GPA translation which is configured as first level page
table in host side for a specific pasid, and host owns GPA->HPA translation.
As guest owns first level translation table, guest's PASID-based IOTLB(piotlb)
flush should be propagated to host since host IOMMU will cache first level
page table related mappings during DMA address translation.
Cc: Kevin Tian <address@hidden>
Cc: Jacob Pan <address@hidden>
Cc: Peter Xu <address@hidden>
Cc: Yi Sun <address@hidden>
Signed-off-by: Liu Yi L <address@hidden>
---
hw/i386/intel_iommu.c | 68 ++++++++++++++++++++++++++++++++++++++++++
hw/i386/intel_iommu_internal.h | 7 +++++
2 files changed, 75 insertions(+)
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index 7a778d8..e4286e5 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -2516,15 +2516,83 @@ static bool vtd_process_pasid_desc(IntelIOMMUState *s,
return (ret == 0) ? true : false;
}
+static inline bool vtd_pasid_cache_valid(VTDAddressSpace *vtd_pasid_as)
+{
+ return (vtd_pasid_as->iommu_state->pasid_cache_gen &&
+ (vtd_pasid_as->iommu_state->pasid_cache_gen
+ == vtd_pasid_as->pasid_cache_entry.pasid_cache_gen));
+}
+
+static void vtd_flush_pasid_iotlb(gpointer key, gpointer value,
+ gpointer user_data)
+{
+ VTDPIOTLBInvInfo *piotlb_info = user_data;
+ VTDAddressSpace *vtd_pasid_as = value;
+ uint16_t did;
+
+ /*
+ * Actually, needs to check whether the pasid entry cache stored in
+ * vtd_pasid_as is valid or not. "invalid" means the pasid cache
+ * has been flushed, thus host should have done such piotlb flush,
+ * no need to pass down piotlb flush to host. Only when pasid entry
+ * cache is "valid", should a piotlb flush pass down to host. Because
+ * In such case, it is due to mapping changes in guest, a piotlb flush
+ * in host is required.
+ */
+ if (!vtd_pasid_as || !vtd_pasid_cache_valid(vtd_pasid_as)) {
+ return;
+ }
+
+ did = vtd_pe_get_domain_id(
+ &(vtd_pasid_as->pasid_cache_entry.pasid_entry));
+ /*
+ * vtd_pasid_as should be non-NULL and the pasid_cache_gen
+ * should be non-zero. If vtd_pasid_as management is clean,
+ * the vtd_pasid_as is non-NULL is enough.
+ */
+ if ((piotlb_info->domain_id == did) &&
+ (piotlb_info->pasid == vtd_pasid_as->pasid)) {
+ pci_device_flush_pasid_iotlb(vtd_pasid_as->bus,
+ vtd_pasid_as->devfn, &piotlb_info->tlb_info);
+ }
+}
+
static void vtd_piotlb_pasid_invalidate(IntelIOMMUState *s,
uint16_t domain_id,
uint32_t pasid)
{
+ VTDPIOTLBInvInfo piotlb_info;
+ struct iommu_cache_invalidate_info *inv_info = &piotlb_info.tlb_info;
+
+ piotlb_info.domain_id = domain_id;
+ piotlb_info.pasid = pasid;
+ inv_info->version = IOMMU_CACHE_INVALIDATE_INFO_VERSION_1;
+ inv_info->cache = IOMMU_CACHE_INV_TYPE_IOTLB;
+ inv_info->granularity = IOMMU_INV_GRANU_PASID;
+ inv_info->pasid_info.pasid = pasid;
+ inv_info->pasid_info.flags = IOMMU_INV_PASID_FLAGS_PASID;
+ g_hash_table_foreach(s->vtd_pasid_as, vtd_flush_pasid_iotlb, &piotlb_info);
}
static void vtd_piotlb_page_invalidate(IntelIOMMUState *s, uint16_t domain_id,
uint32_t pasid, hwaddr addr, uint8_t am, bool ih)
{
+ VTDPIOTLBInvInfo piotlb_info;
+ struct iommu_cache_invalidate_info *inv_info = &piotlb_info.tlb_info;
+
+ piotlb_info.domain_id = domain_id;
+ piotlb_info.pasid = pasid;
+ inv_info->version = IOMMU_CACHE_INVALIDATE_INFO_VERSION_1;
+ inv_info->cache = IOMMU_CACHE_INV_TYPE_IOTLB;
+ inv_info->granularity = IOMMU_INV_GRANU_ADDR;
+ inv_info->addr_info.flags = IOMMU_INV_ADDR_FLAGS_PASID;
+ inv_info->addr_info.flags |= ih ? IOMMU_INV_ADDR_FLAGS_LEAF : 0;
+ inv_info->addr_info.pasid = pasid;
+ inv_info->addr_info.addr = addr;
+ inv_info->addr_info.granule_size = 1 << (12 + am);
+ inv_info->addr_info.nb_granules = 1;
+
+ g_hash_table_foreach(s->vtd_pasid_as, vtd_flush_pasid_iotlb, &piotlb_info);
}
static bool vtd_process_piotlb_desc(IntelIOMMUState *s,
diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h
index 69cd879..556ea8d 100644
--- a/hw/i386/intel_iommu_internal.h
+++ b/hw/i386/intel_iommu_internal.h
@@ -506,6 +506,13 @@ struct VTDPASIDCacheInfo {
};
typedef struct VTDPASIDCacheInfo VTDPASIDCacheInfo;
+struct VTDPIOTLBInvInfo {
+ uint16_t domain_id;
+ uint32_t pasid;
+ struct iommu_cache_invalidate_info tlb_info;
+};
+typedef struct VTDPIOTLBInvInfo VTDPIOTLBInvInfo;
+
/* Masks for struct VTDRootEntry */
#define VTD_ROOT_ENTRY_P 1ULL
#define VTD_ROOT_ENTRY_CTP (~0xfffULL)
--
2.7.4
- Re: [Qemu-devel] [RFC v1 11/18] intel_iommu: create VTDAddressSpace per BDF+PASID, (continued)
- [Qemu-devel] [RFC v1 10/18] intel_iommu: tag VTDAddressSpace instance with PASID, Liu Yi L, 2019/07/06
- [Qemu-devel] [RFC v1 12/18] intel_iommu: bind/unbind guest page table to host, Liu Yi L, 2019/07/06
- [Qemu-devel] [RFC v1 14/18] hw/pci: add flush_pasid_iotlb() in PCIPASIDOps, Liu Yi L, 2019/07/06
- [Qemu-devel] [RFC v1 16/18] intel_iommu: add PASID-based iotlb invalidation support, Liu Yi L, 2019/07/06
- [Qemu-devel] [RFC v1 13/18] intel_iommu: flush pasid cache after a DSI context cache flush, Liu Yi L, 2019/07/06
- [Qemu-devel] [RFC v1 15/18] vfio/pci: adds support for PASID-based iotlb flush, Liu Yi L, 2019/07/06
- [Qemu-devel] [RFC v1 17/18] intel_iommu: propagate PASID-based iotlb flush to host,
Liu Yi L <=
- [Qemu-devel] [RFC v1 18/18] intel_iommu: do not passdown pasid bind for PASID #0, Liu Yi L, 2019/07/06