Re: [Qemu-devel] [PULL v6 00/42] Machine and x86 queue, 2019-07-05

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL v6 00/42] Machine and x86 queue, 2019-07-05

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
8222dd1 tests: use -numa memdev option in tests instead of legacy 'mem' option
17f968f numa: allow memory-less nodes when using memdev as backend
ba5a8f5 numa: Make deprecation warnings conditional on !qtest_enabled()
e7eed65 i386: Add Cascadelake-Server-v2 CPU model
c270e11 docs: Deprecate CPU model runnability guarantees
d148782 i386: Make unversioned CPU models be aliases
212584e i386: Replace -noTSX, -IBRS, -IBPB CPU models with aliases
14bea5f i386: Define -IBRS, -noTSX, -IBRS versions of CPU models
abe39dc i386: Register versioned CPU models
43e890f i386: Get model-id from CPU object on "-cpu help"
86bad9a i386: Add x-force-features option for testing
3764570 qmp: Add "alias-of" field to query-cpu-definitions
2136259 i386: Introduce SnowRidge CPU model
5c64e25 qmp: Add deprecation information to query-machines
d9fca16 vl.c: Add -smp, dies=* command line support and update doc
58066f7 machine: Refactor smp_parse() in vl.c as MachineClass::smp_parse()
e5521eb target/i386: Add CPUID.1F generation support for multi-dies PCMachine
efe9c60 i386: Remove unused host_cpudef variable
c786127 x86/cpu: use FeatureWordArray to define filtered_features
599f2d2 i386: make 'hv-spinlocks' a regular uint32 property
12b504f i386: Fix signedness of hyperv_spinlock_attempts
51b09c1 i386: Don't print warning if phys-bits was set automatically
940f005 deprecate -mem-path fallback to anonymous RAM
b60560d hppa: Delete unused hppa_cpu_list() function
79ffefd numa: deprecate implict memory distribution between nodes
f7fc9c7 numa: deprecate 'mem' parameter of '-numa node' option
4760053 machine: show if CLI option '-numa node, mem' is supported in QAPI 
schema
c445aeb pc: fix possible NULL pointer dereference in 
pc_machine_get_device_memory_region_size()
08979e7 i386: Update new x86_apicid parsing rules with die_offset support
877b166 i386/cpu: Consolidate die-id validity in smp context
6ed8e31 hw/i386: Adjust nr_dies with configured smp_dies for PCMachine
5a48895 i386: Add die-level cpu topology to x86CPU on PCMachine
a468b59 vl.c: Replace smp global variables with smp machine properties
0f5c31d hw: Replace global smp variables with MachineState for all remaining 
archs
f5605f8 hw/arm: Replace global smp variables with machine smp properties
b6ed3fc hw/i386: Replace global smp variables with machine smp properties
90c875c hw/s390x: Replace global smp variables with machine smp properties
ed06b18 hw/riscv: Replace global smp variables with machine smp properties
e180e9c hw/ppc: Replace global smp variables with machine smp properties
99fae98 general: Replace global smp variables with smp machine properties
442604b machine: Refactor smp-related call chains to pass MachineState
b9ea53f hw/boards: Add struct CpuTopology to MachineState

=== OUTPUT BEGIN ===
1/42 Checking commit b9ea53f93d3b (hw/boards: Add struct CpuTopology to 
MachineState)
2/42 Checking commit 442604b2a8f7 (machine: Refactor smp-related call chains to 
pass MachineState)
3/42 Checking commit 99fae98b339d (general: Replace global smp variables with 
smp machine properties)
4/42 Checking commit e180e9c58736 (hw/ppc: Replace global smp variables with 
machine smp properties)
5/42 Checking commit ed06b18ac991 (hw/riscv: Replace global smp variables with 
machine smp properties)
6/42 Checking commit 90c875c003ca (hw/s390x: Replace global smp variables with 
machine smp properties)
7/42 Checking commit b6ed3fcd0057 (hw/i386: Replace global smp variables with 
machine smp properties)
8/42 Checking commit f5605f812d27 (hw/arm: Replace global smp variables with 
machine smp properties)
9/42 Checking commit 0f5c31d7d679 (hw: Replace global smp variables with 
MachineState for all remaining archs)
10/42 Checking commit a468b5935abe (vl.c: Replace smp global variables with smp 
machine properties)
11/42 Checking commit 5a48895d51e5 (i386: Add die-level cpu topology to x86CPU 
on PCMachine)
12/42 Checking commit 6ed8e31874e1 (hw/i386: Adjust nr_dies with configured 
smp_dies for PCMachine)
13/42 Checking commit 877b1661e86d (i386/cpu: Consolidate die-id validity in 
smp context)
14/42 Checking commit 08979e7e3e98 (i386: Update new x86_apicid parsing rules 
with die_offset support)
15/42 Checking commit c445aebbc23b (pc: fix possible NULL pointer dereference 
in pc_machine_get_device_memory_region_size())
16/42 Checking commit 4760053c2d35 (machine: show if CLI option '-numa node, 
mem' is supported in QAPI schema)
17/42 Checking commit f7fc9c769452 (numa: deprecate 'mem' parameter of '-numa 
node' option)
18/42 Checking commit 79ffefdf89eb (numa: deprecate implict memory distribution 
between nodes)
19/42 Checking commit b60560d9a1d6 (hppa: Delete unused hppa_cpu_list() 
function)
20/42 Checking commit 940f005a14e4 (deprecate -mem-path fallback to anonymous 
RAM)
21/42 Checking commit 51b09c151c24 (i386: Don't print warning if phys-bits was 
set automatically)
22/42 Checking commit 12b504ff090c (i386: Fix signedness of 
hyperv_spinlock_attempts)
23/42 Checking commit 599f2d213701 (i386: make 'hv-spinlocks' a regular uint32 
property)
24/42 Checking commit c78612762a38 (x86/cpu: use FeatureWordArray to define 
filtered_features)
25/42 Checking commit efe9c60dcf40 (i386: Remove unused host_cpudef variable)
26/42 Checking commit e5521ebe5c06 (target/i386: Add CPUID.1F generation 
support for multi-dies PCMachine)
27/42 Checking commit 58066f711480 (machine: Refactor smp_parse() in vl.c as 
MachineClass::smp_parse())
28/42 Checking commit d9fca162e23f (vl.c: Add -smp, dies=* command line support 
and update doc)
29/42 Checking commit 5c64e254f4eb (qmp: Add deprecation information to 
query-machines)
30/42 Checking commit 21362596beb9 (i386: Introduce SnowRidge CPU model)
31/42 Checking commit 376457065ee8 (qmp: Add "alias-of" field to 
query-cpu-definitions)
32/42 Checking commit 86bad9a396fc (i386: Add x-force-features option for 
testing)
33/42 Checking commit 43e890fc16cb (i386: Get model-id from CPU object on "-cpu 
help")
34/42 Checking commit abe39dcbb8da (i386: Register versioned CPU models)
WARNING: line over 80 characters
#100: FILE: target/i386/cpu.c:1482:
+static const X86CPUVersionDefinition 
*x86_cpu_def_get_versions(X86CPUDefinition *def)

WARNING: Block comments use a leading /* on a separate line
#105: FILE: target/i386/cpu.c:1487:
+        { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#122: FILE: target/i386/cpu.c:1883:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#134: FILE: target/i386/cpu.c:1942:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#146: FILE: target/i386/cpu.c:2011:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#158: FILE: target/i386/cpu.c:2086:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#170: FILE: target/i386/cpu.c:2127:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#182: FILE: target/i386/cpu.c:2170:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#194: FILE: target/i386/cpu.c:2251:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#206: FILE: target/i386/cpu.c:2294:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#218: FILE: target/i386/cpu.c:2339:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#230: FILE: target/i386/cpu.c:2422:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#242: FILE: target/i386/cpu.c:2519:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#254: FILE: target/i386/cpu.c:2626:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: Block comments use a leading /* on a separate line
#266: FILE: target/i386/cpu.c:3139:
+        .versions = (X86CPUVersionDefinition[]) { { /* end of list */ } },

WARNING: line over 80 characters
#333: FILE: target/i386/cpu.c:4117:
+    for (vdef = x86_cpu_def_get_versions(model->cpudef); vdef->version; 
vdef++) {

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#509: 
new file mode 100644

ERROR: line over 90 characters
#552: FILE: tests/acceptance/x86_cpu_model_versions.py:39:
+                              '%s.alias-of (%s) is not a valid CPU model name' 
% (c['name'], c['alias-of']))

ERROR: line over 90 characters
#555: FILE: tests/acceptance/x86_cpu_model_versions.py:42:
+                                 '%s.alias-of (%s) points to another alias' % 
(c['name'], c['alias-of']))

WARNING: line over 80 characters
#591: FILE: tests/acceptance/x86_cpu_model_versions.py:78:
+        """Check if pc-*-4.0 unversioned CPU model won't be reported as 
aliases"""

WARNING: line over 80 characters
#598: FILE: tests/acceptance/x86_cpu_model_versions.py:85:
+        cpus = dict((m['name'], m) for m in 
self.vm.command('query-cpu-definitions'))

WARNING: line over 80 characters
#601: FILE: tests/acceptance/x86_cpu_model_versions.py:88:
+                         'unversioned Cascadelake-Server CPU model must not be 
static')

total: 2 errors, 20 warnings, 550 lines checked

Patch 34/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

35/42 Checking commit 14bea5fba448 (i386: Define -IBRS, -noTSX, -IBRS versions 
of CPU models)
WARNING: Block comments use a leading /* on a separate line
#36: FILE: target/i386/cpu.c:1863:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#39: FILE: target/i386/cpu.c:1866:
+            { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#57: FILE: target/i386/cpu.c:1933:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#60: FILE: target/i386/cpu.c:1936:
+            { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#78: FILE: target/i386/cpu.c:2011:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#81: FILE: target/i386/cpu.c:2014:
+            { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#99: FILE: target/i386/cpu.c:2097:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#102: FILE: target/i386/cpu.c:2100:
+            { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#121: FILE: target/i386/cpu.c:2274:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#139: FILE: target/i386/cpu.c:2292:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#152: FILE: target/i386/cpu.c:2305:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#155: FILE: target/i386/cpu.c:2308:
+            { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#173: FILE: target/i386/cpu.c:2489:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#186: FILE: target/i386/cpu.c:2502:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#198: FILE: target/i386/cpu.c:2514:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#201: FILE: target/i386/cpu.c:2517:
+            { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#219: FILE: target/i386/cpu.c:2618:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#222: FILE: target/i386/cpu.c:2621:
+            { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#243: FILE: target/i386/cpu.c:2737:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#246: FILE: target/i386/cpu.c:2740:
+            { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#264: FILE: target/i386/cpu.c:3266:
+                    { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#267: FILE: target/i386/cpu.c:3269:
+            { /* end of list */ }

total: 0 errors, 22 warnings, 240 lines checked

Patch 35/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
36/42 Checking commit 212584e2a174 (i386: Replace -noTSX, -IBRS, -IBPB CPU 
models with aliases)
37/42 Checking commit d14878267940 (i386: Make unversioned CPU models be 
aliases)
WARNING: line over 80 characters
#267: FILE: tests/acceptance/x86_cpu_model_versions.py:108:
+        """Check if unversioned CPU model is an alias pointing to right 
version"""

WARNING: line over 80 characters
#272: FILE: tests/acceptance/x86_cpu_model_versions.py:113:
+        cpus = dict((m['name'], m) for m in 
self.vm.command('query-cpu-definitions'))

WARNING: line over 80 characters
#275: FILE: tests/acceptance/x86_cpu_model_versions.py:116:
+                         'unversioned Cascadelake-Server CPU model must not be 
static')

ERROR: line over 90 characters
#276: FILE: tests/acceptance/x86_cpu_model_versions.py:117:
+        self.assertEquals(cpus['Cascadelake-Server'].get('alias-of'), 
'Cascadelake-Server-v1',

WARNING: line over 80 characters
#277: FILE: tests/acceptance/x86_cpu_model_versions.py:118:
+                          'Cascadelake-Server must be an alias of 
Cascadelake-Server-v1')

WARNING: line over 80 characters
#369: FILE: tests/acceptance/x86_cpu_model_versions.py:210:
+        """Check if unversioned CPU model is an alias pointing to some 
version"""

WARNING: line over 80 characters
#374: FILE: tests/acceptance/x86_cpu_model_versions.py:215:
+        cpus = dict((m['name'], m) for m in 
self.vm.command('query-cpu-definitions'))

WARNING: line over 80 characters
#377: FILE: tests/acceptance/x86_cpu_model_versions.py:218:
+                         'unversioned Cascadelake-Server CPU model must not be 
static')

ERROR: line over 90 characters
#378: FILE: tests/acceptance/x86_cpu_model_versions.py:219:
+        self.assertTrue(re.match('Cascadelake-Server-v[0-9]+', 
cpus['Cascadelake-Server']['alias-of']),

WARNING: line over 80 characters
#379: FILE: tests/acceptance/x86_cpu_model_versions.py:220:
+                        'Cascadelake-Server must be an alias of versioned CPU 
model')

total: 2 errors, 8 warnings, 319 lines checked

Patch 37/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

38/42 Checking commit c270e116f3d0 (docs: Deprecate CPU model runnability 
guarantees)
39/42 Checking commit e7eed65410f0 (i386: Add Cascadelake-Server-v2 CPU model)
WARNING: Block comments use a leading /* on a separate line
#46: FILE: target/i386/cpu.c:2355:
+                  { /* end of list */ }

WARNING: Block comments use a leading /* on a separate line
#49: FILE: target/i386/cpu.c:2358:
+            { /* end of list */ }

ERROR: line over 90 characters
#79: FILE: tests/acceptance/x86_cpu_model_versions.py:242:
+        vm.add_args('-cpu', 
'Cascadelake-Server,x-force-features=on,check=off,enforce=off')

ERROR: line over 90 characters
#82: FILE: tests/acceptance/x86_cpu_model_versions.py:245:
+                         'pc-i440fx-4.1 + Cascadelake-Server should not have 
arch-capabilities')

ERROR: line over 90 characters
#87: FILE: tests/acceptance/x86_cpu_model_versions.py:250:
+        vm.add_args('-cpu', 
'Cascadelake-Server,x-force-features=on,check=off,enforce=off')

ERROR: line over 90 characters
#90: FILE: tests/acceptance/x86_cpu_model_versions.py:253:
+                         'pc-i440fx-4.0 + Cascadelake-Server should not have 
arch-capabilities')

ERROR: line over 90 characters
#96: FILE: tests/acceptance/x86_cpu_model_versions.py:259:
+        vm.add_args('-cpu', 
'Cascadelake-Server,x-force-features=on,check=off,enforce=off,+arch-capabilities')

ERROR: line over 90 characters
#99: FILE: tests/acceptance/x86_cpu_model_versions.py:262:
+                        'pc-i440fx-4.0 + Cascadelake-Server,+arch-capabilities 
should have arch-capabilities')

ERROR: line over 90 characters
#104: FILE: tests/acceptance/x86_cpu_model_versions.py:267:
+        vm.add_args('-cpu', 
'Cascadelake-Server,x-force-features=on,check=off,enforce=off,-arch-capabilities')

ERROR: line over 90 characters
#107: FILE: tests/acceptance/x86_cpu_model_versions.py:270:
+                         'pc-i440fx-4.1 + 
Cascadelake-Server,-arch-capabilities should not have arch-capabilities')

ERROR: line over 90 characters
#113: FILE: tests/acceptance/x86_cpu_model_versions.py:276:
+        vm.add_args('-cpu', 
'Cascadelake-Server-v1,x-force-features=on,check=off,enforce=off')

ERROR: line over 90 characters
#116: FILE: tests/acceptance/x86_cpu_model_versions.py:279:
+                         'pc-i440fx-4.1 + Cascadelake-Server-v1 should not 
have arch-capabilities')

ERROR: line over 90 characters
#121: FILE: tests/acceptance/x86_cpu_model_versions.py:284:
+        vm.add_args('-cpu', 
'Cascadelake-Server-v2,x-force-features=on,check=off,enforce=off')

ERROR: line over 90 characters
#124: FILE: tests/acceptance/x86_cpu_model_versions.py:287:
+                         'pc-i440fx-4.1 + Cascadelake-Server-v1 should have 
arch-capabilities')

ERROR: line over 90 characters
#130: FILE: tests/acceptance/x86_cpu_model_versions.py:293:
+        vm.add_args('-cpu', 
'Cascadelake-Server,x-force-features=on,check=off,enforce=off,+arch-capabilities')

ERROR: line over 90 characters
#133: FILE: tests/acceptance/x86_cpu_model_versions.py:296:
+                         'pc-i440fx-4.0 + 
Cascadelake-Server-v1,+arch-capabilities should have arch-capabilities')

ERROR: line over 90 characters
#138: FILE: tests/acceptance/x86_cpu_model_versions.py:301:
+        vm.add_args('-cpu', 
'Cascadelake-Server-v2,x-force-features=on,check=off,enforce=off,-arch-capabilities')

ERROR: line over 90 characters
#141: FILE: tests/acceptance/x86_cpu_model_versions.py:304:
+                         'pc-i440fx-4.1 + 
Cascadelake-Server-v2,-arch-capabilities should not have arch-capabilities')

total: 16 errors, 2 warnings, 102 lines checked

Patch 39/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

40/42 Checking commit ba5a8f5a94ae (numa: Make deprecation warnings conditional 
on !qtest_enabled())
WARNING: line over 80 characters
#52: FILE: hw/core/numa.c:412:
+                warn_report("Default splitting of RAM between nodes is 
deprecated,"

total: 0 errors, 1 warnings, 33 lines checked

Patch 40/42 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
41/42 Checking commit 17f968fb74da (numa: allow memory-less nodes when using 
memdev as backend)
42/42 Checking commit 8222dd14a69f (tests: use -numa memdev option in tests 
instead of legacy 'mem' option)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden