[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 02/12] checkpatch: do not warn for multiline parenthe
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 02/12] checkpatch: do not warn for multiline parenthesized returned value |
Date: |
Fri, 5 Jul 2019 21:50:29 +0200 |
While indeed we do not want to have
return (a);
it is less clear that this applies to
return (a &&
b);
Some editors indent more nicely if you have parentheses, and some people's
eyes may appreciate that as well.
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
scripts/checkpatch.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index c2aaf42..2f81371 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2296,7 +2296,8 @@ sub process {
$value =~ s/\([^\(\)]*\)/1/) {
}
#print "value<$value>\n";
- if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/) {
+ if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/ &&
+ $line =~ /;$/) {
ERROR("return is not a function, parentheses
are not required\n" . $herecurr);
} elsif ($spacing !~ /\s+/) {
--
1.8.3.1
- [Qemu-devel] [PULL 00/12] Misc bugfixes for QEMU hard freeze, Paolo Bonzini, 2019/07/05
- [Qemu-devel] [PULL 02/12] checkpatch: do not warn for multiline parenthesized returned value,
Paolo Bonzini <=
- [Qemu-devel] [PULL 01/12] pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size(), Paolo Bonzini, 2019/07/05
- [Qemu-devel] [PULL 03/12] i386/kvm: Fix build with -m32, Paolo Bonzini, 2019/07/05
- [Qemu-devel] [PULL 04/12] intel_iommu: Fix incorrect "end" for vtd_address_space_unmap, Paolo Bonzini, 2019/07/05
- [Qemu-devel] [PULL 06/12] ioapic: clear irq_eoi when updating the ioapic redirect table entry, Paolo Bonzini, 2019/07/05
- [Qemu-devel] [PULL 05/12] intel_iommu: Fix unexpected unmaps during global unmap, Paolo Bonzini, 2019/07/05
- [Qemu-devel] [PULL 07/12] target/i386: fix feature check in hyperv-stub.c, Paolo Bonzini, 2019/07/05
- [Qemu-devel] [PULL 08/12] minikconf: do not include variables from MINIKCONF_ARGS in config-all-devices.mak, Paolo Bonzini, 2019/07/05
- [Qemu-devel] [PULL 09/12] target/i386: kvm: Fix when nested state is needed for migration, Paolo Bonzini, 2019/07/05
- [Qemu-devel] [PULL 10/12] Makefile: generate header file with the list of devices enabled, Paolo Bonzini, 2019/07/05
- [Qemu-devel] [PULL 11/12] hw/i386: Fix linker error when ISAPC is disabled, Paolo Bonzini, 2019/07/05