|
| From: | Richard Henderson |
| Subject: | Re: [Qemu-devel] [PATCH v1 1/4] target/arm: handle M-profile semihosting at translate time |
| Date: | Wed, 3 Jul 2019 18:26:52 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 |
On 7/3/19 5:52 PM, Alex Bennée wrote:
> +static inline void gen_thumb_bkpt(DisasContext *s, int imm8)
> +{
> + if (arm_dc_feature(s, ARM_FEATURE_M) &&
> + semihosting_enabled() &&
> +#ifndef CONFIG_USER_ONLY
> + s->current_el != 0 &&
> +#endif
> + (imm8 == 0xab)) {
Extra parenthesis. Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~
| [Prev in Thread] | Current Thread | [Next in Thread] |