[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] tests: use -numa memdev option in tests ins
Re: [Qemu-devel] [PATCH 2/2] tests: use -numa memdev option in tests instead of legacy 'mem' option
Wed, 3 Jul 2019 14:13:39 +0200
On Tue, 2 Jul 2019 19:03:10 -0300
Eduardo Habkost <address@hidden> wrote:
> On Tue, Jul 02, 2019 at 02:19:01PM -0300, Eduardo Habkost wrote:
> > On Tue, Jul 02, 2019 at 10:07:45AM -0400, Igor Mammedov wrote:
> > > it will test preferred memdev option more extensively and remove
> > > undesired deprecation warnings during 'make check'
> > >
> > > Signed-off-by: Igor Mammedov <address@hidden>
> > > ---
> > [...]
> > > diff --git a/tests/numa-test.c b/tests/numa-test.c
> > > index 8de8581231..902e8de4d1 100644
> > > --- a/tests/numa-test.c
> > > +++ b/tests/numa-test.c
> > > @@ -26,8 +26,10 @@ static void test_mon_explicit(const void *data)
> > > QTestState *qts;
> > >
> > > cli = make_cli(data, "-smp 8 "
> > > - "-numa node,nodeid=0,cpus=0-3 "
> > > - "-numa node,nodeid=1,cpus=4-7 ");
> > > + "-object memory-backend-ram,id=ram0,size=64M "
> > > + "-object memory-backend-ram,id=ram1,size=64M "
> > > + "-numa node,nodeid=0,cpus=0-3,memdev=ram0 "
> > > + "-numa node,nodeid=1,cpus=4-7,memdev=ram1 ");
> > These changes break on ppc64, where default RAM size is 512 MiB
> > and it has to be a multiple of 256 MiB.
> > Can't we just make the warnings be conditional on
> > !qtest_enabled(), like we already do elsewhere?
> The answer is: we can, but this is not enough for
> bios-tables-test.c because it doesn't use accel=qtest. I've
> removed the numa-test.c changes from this patch, and added the
> fix I have submitted at:
> Subject: numa: Make deprecation warnings conditional on !qtest_enabled()
> Message-Id: <address@hidden>
acked as it fixes immediate issue with warnings.
I'll work on numa-test.c some more, since simple replacing of
mem with memdev is not enough