[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 10/12] target/mips: Correct comments in msa_helper.c
From: |
Aleksandar Markovic |
Subject: |
[Qemu-devel] [PULL 10/12] target/mips: Correct comments in msa_helper.c |
Date: |
Tue, 2 Jul 2019 18:35:26 +0200 |
From: Aleksandar Markovic <address@hidden>
Fix some errors in comments for MSA helpers.
Signed-off-by: Aleksandar Markovic <address@hidden>
Reviewed-by: Aleksandar Rikalo <address@hidden>
Message-Id: <address@hidden>
---
target/mips/msa_helper.c | 58 ++++++++++++++++++++++++++++++++++--------------
1 file changed, 41 insertions(+), 17 deletions(-)
diff --git a/target/mips/msa_helper.c b/target/mips/msa_helper.c
index 8bad636..5377bc1 100644
--- a/target/mips/msa_helper.c
+++ b/target/mips/msa_helper.c
@@ -72,9 +72,6 @@
* --------
*
* +---------------+----------------------------------------------------------+
- * | BMNZ.V | Vector Bit Move If Not Zero |
- * | BMZ.V | Vector Bit Move If Zero |
- * | BSEL.V | Vector Bit Select |
* | BINSL.B | Vector Bit Insert Left (byte) |
* | BINSL.H | Vector Bit Insert Left (halfword) |
* | BINSL.W | Vector Bit Insert Left (word) |
@@ -83,6 +80,9 @@
* | BINSR.H | Vector Bit Insert Right (halfword) |
* | BINSR.W | Vector Bit Insert Right (word) |
* | BINSR.D | Vector Bit Insert Right (doubleword) |
+ * | BMNZ.V | Vector Bit Move If Not Zero |
+ * | BMZ.V | Vector Bit Move If Zero |
+ * | BSEL.V | Vector Bit Select |
* +---------------+----------------------------------------------------------+
*/
@@ -179,12 +179,12 @@
* | ADDV.H | Vector Add (halfword) |
* | ADDV.W | Vector Add (word) |
* | ADDV.D | Vector Add (doubleword) |
- * | HSUB_S.H | Vector Signed Horizontal Add (halfword) |
- * | HSUB_S.W | Vector Signed Horizontal Add (word) |
- * | HSUB_S.D | Vector Signed Horizontal Add (doubleword) |
- * | HSUB_U.H | Vector Unigned Horizontal Add (halfword) |
- * | HSUB_U.W | Vector Unigned Horizontal Add (word) |
- * | HSUB_U.D | Vector Unigned Horizontal Add (doubleword) |
+ * | HADD_S.H | Vector Signed Horizontal Add (halfword) |
+ * | HADD_S.W | Vector Signed Horizontal Add (word) |
+ * | HADD_S.D | Vector Signed Horizontal Add (doubleword) |
+ * | HADD_U.H | Vector Unigned Horizontal Add (halfword) |
+ * | HADD_U.W | Vector Unigned Horizontal Add (word) |
+ * | HADD_U.D | Vector Unigned Horizontal Add (doubleword) |
* +---------------+----------------------------------------------------------+
*/
@@ -279,6 +279,18 @@
* | DOTP_U.H | Vector Unsigned Dot Product (halfword) |
* | DOTP_U.W | Vector Unsigned Dot Product (word) |
* | DOTP_U.D | Vector Unsigned Dot Product (doubleword) |
+ * | DPADD_S.H | Vector Signed Dot Product (halfword) |
+ * | DPADD_S.W | Vector Signed Dot Product (word) |
+ * | DPADD_S.D | Vector Signed Dot Product (doubleword) |
+ * | DPADD_U.H | Vector Unsigned Dot Product (halfword) |
+ * | DPADD_U.W | Vector Unsigned Dot Product (word) |
+ * | DPADD_U.D | Vector Unsigned Dot Product (doubleword) |
+ * | DPSUB_S.H | Vector Signed Dot Product (halfword) |
+ * | DPSUB_S.W | Vector Signed Dot Product (word) |
+ * | DPSUB_S.D | Vector Signed Dot Product (doubleword) |
+ * | DPSUB_U.H | Vector Unsigned Dot Product (halfword) |
+ * | DPSUB_U.W | Vector Unsigned Dot Product (word) |
+ * | DPSUB_U.D | Vector Unsigned Dot Product (doubleword) |
* +---------------+----------------------------------------------------------+
*/
@@ -389,14 +401,14 @@
* | SUBS_U.H | Vector Unsigned Saturated Subtract (of Uns.) (halfword) |
* | SUBS_U.W | Vector Unsigned Saturated Subtract (of Uns.) (word) |
* | SUBS_U.D | Vector Unsigned Saturated Subtract (of Uns.) (doubleword)|
- * | SUBSUS_S.B | Vector Uns. Sat. Subtract (of S. from Uns.) (byte) |
- * | SUBSUS_S.H | Vector Uns. Sat. Subtract (of S. from Uns.) (halfword) |
- * | SUBSUS_S.W | Vector Uns. Sat. Subtract (of S. from Uns.) (word) |
- * | SUBSUS_S.D | Vector Uns. Sat. Subtract (of S. from Uns.) (doubleword) |
- * | SUBSUU_U.B | Vector Signed Saturated Subtract (of Uns.) (byte) |
- * | SUBSUU_U.H | Vector Signed Saturated Subtract (of Uns.) (halfword) |
- * | SUBSUU_U.W | Vector Signed Saturated Subtract (of Uns.) (word) |
- * | SUBSUU_U.D | Vector Signed Saturated Subtract (of Uns.) (doubleword) |
+ * | SUBSUS_U.B | Vector Uns. Sat. Subtract (of S. from Uns.) (byte) |
+ * | SUBSUS_U.H | Vector Uns. Sat. Subtract (of S. from Uns.) (halfword) |
+ * | SUBSUS_U.W | Vector Uns. Sat. Subtract (of S. from Uns.) (word) |
+ * | SUBSUS_U.D | Vector Uns. Sat. Subtract (of S. from Uns.) (doubleword) |
+ * | SUBSUU_S.B | Vector Signed Saturated Subtract (of Uns.) (byte) |
+ * | SUBSUU_S.H | Vector Signed Saturated Subtract (of Uns.) (halfword) |
+ * | SUBSUU_S.W | Vector Signed Saturated Subtract (of Uns.) (word) |
+ * | SUBSUU_S.D | Vector Signed Saturated Subtract (of Uns.) (doubleword) |
* | SUBV.B | Vector Subtract (byte) |
* | SUBV.H | Vector Subtract (halfword) |
* | SUBV.W | Vector Subtract (word) |
@@ -450,6 +462,18 @@
/*
+ * Move
+ * ----
+ *
+ * +---------------+----------------------------------------------------------+
+ * | MOVE.V | Vector Move |
+ * +---------------+----------------------------------------------------------+
+ */
+
+/* TODO: insert Move group helpers here */
+
+
+/*
* Pack
* ----
*
--
2.7.4
- [Qemu-devel] [PULL 00/12] MIPS queue for July 2nd, 2019, Aleksandar Markovic, 2019/07/02
- [Qemu-devel] [PULL 03/12] hw/mips: Express dependencies of the MIPSsim machine with Kconfig, Aleksandar Markovic, 2019/07/02
- [Qemu-devel] [PULL 04/12] hw/mips: Express dependencies of the Jazz machine with Kconfig, Aleksandar Markovic, 2019/07/02
- [Qemu-devel] [PULL 02/12] hw/mips: Explicit the semi-hosting feature is always required, Aleksandar Markovic, 2019/07/02
- [Qemu-devel] [PULL 10/12] target/mips: Correct comments in msa_helper.c,
Aleksandar Markovic <=
- [Qemu-devel] [PULL 01/12] tests/machine-none: Test recent MIPS cpus, Aleksandar Markovic, 2019/07/02
- [Qemu-devel] [PULL 05/12] hw/mips: Express dependencies of the r4k platform with Kconfig, Aleksandar Markovic, 2019/07/02
- [Qemu-devel] [PULL 12/12] target/mips: Correct helper for MSA FCLASS.<W|D> instructions, Aleksandar Markovic, 2019/07/02
- [Qemu-devel] [PULL 11/12] target/mips: Unroll loops for MSA float max/min instructions, Aleksandar Markovic, 2019/07/02
- [Qemu-devel] [PULL 08/12] tcg/tests: target/mips: Correct MSA test compilation and execution order, Aleksandar Markovic, 2019/07/02
- [Qemu-devel] [PULL 09/12] target/mips: Correct comments in translate.c, Aleksandar Markovic, 2019/07/02
- [Qemu-devel] [PULL 07/12] tcg/tests: target/mips: Amend MSA integer multiply tests, Aleksandar Markovic, 2019/07/02
- [Qemu-devel] [PULL 06/12] tcg/tests: target/mips: Amend MSA fixed point multiply tests, Aleksandar Markovic, 2019/07/02
- Re: [Qemu-devel] [PULL 00/12] MIPS queue for July 2nd, 2019, no-reply, 2019/07/02
- Re: [Qemu-devel] [PULL 00/12] MIPS queue for July 2nd, 2019, no-reply, 2019/07/03