[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 3/3] vfio/common: Introduce vfio_set_irq_signalin

From: Peter Maydell
Subject: Re: [Qemu-devel] [PULL 3/3] vfio/common: Introduce vfio_set_irq_signaling helper
Date: Tue, 2 Jul 2019 16:58:02 +0100

On Tue, 2 Jul 2019 at 16:56, Alex Williamson <address@hidden> wrote:
> When we're emulating writes to the MSI-X vector table we have no
> failure path up to the guest.  Real hardware cannot fail to enable a
> vector that's available in hardware, thus we can either log the issue,
> ignore the issue, or fault.  I guess Coverity is simply noting that
> other cases are tested while this is not, therefore we should either
> explicitly ignore the return value with a cast to void or take this as
> an opportunity to log the fault, which might be useful in debugging a
> device that isn't working properly.  Thanks,

Yeah, Coverity's check here is purely a heuristic ("did we seem
to check returns from this function in other places?") so it's
wrong sometimes. If you want me to mark this as a false positive
in the coverity UI I can do that.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]