[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 5/6] linux-user: Handle EXCP_FPE properly for MIPS
From: |
Laurent Vivier |
Subject: |
[Qemu-devel] [PULL 5/6] linux-user: Handle EXCP_FPE properly for MIPS |
Date: |
Tue, 2 Jul 2019 17:05:44 +0200 |
From: Aleksandar Markovic <address@hidden>
Handle EXCP_FPE properly for MIPS in cpu loop.
Note that a vast majority of FP instructions are not affected by
the absence of the code in this patch, as they use alternative code
paths for handling floating point exceptions (see, for example,
invocations of update_fcr31()) - they rely on softfloat library for
keeping track on exceptions that needs to be raised. However, there
are few MIPS FP instructions (an example is CTC1) that use function
do_raise_exception() directly, and they need the case that is added
in this patch to propagate the FPE exception as designed.
The code is based on kernel's function force_fcr31_sig() in
arch/mips/kernel.traps.c.
Reported-by: Yunqiang Su <address@hidden>
Signed-off-by: Aleksandar Markovic <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
linux-user/mips/cpu_loop.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/linux-user/mips/cpu_loop.c b/linux-user/mips/cpu_loop.c
index 43ba26754736..0ba894fa7aa5 100644
--- a/linux-user/mips/cpu_loop.c
+++ b/linux-user/mips/cpu_loop.c
@@ -540,6 +540,23 @@ done_syscall:
info.si_code = TARGET_ILL_ILLOPC;
queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
break;
+ case EXCP_FPE:
+ info.si_signo = TARGET_SIGFPE;
+ info.si_errno = 0;
+ info.si_code = TARGET_FPE_FLTUNK;
+ if (GET_FP_CAUSE(env->active_fpu.fcr31) & FP_INVALID) {
+ info.si_code = TARGET_FPE_FLTINV;
+ } else if (GET_FP_CAUSE(env->active_fpu.fcr31) & FP_DIV0) {
+ info.si_code = TARGET_FPE_FLTDIV;
+ } else if (GET_FP_CAUSE(env->active_fpu.fcr31) & FP_OVERFLOW) {
+ info.si_code = TARGET_FPE_FLTOVF;
+ } else if (GET_FP_CAUSE(env->active_fpu.fcr31) & FP_UNDERFLOW) {
+ info.si_code = TARGET_FPE_FLTUND;
+ } else if (GET_FP_CAUSE(env->active_fpu.fcr31) & FP_INEXACT) {
+ info.si_code = TARGET_FPE_FLTRES;
+ }
+ queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
+ break;
/* The code below was inspired by the MIPS Linux kernel trap
* handling code in arch/mips/kernel/traps.c.
*/
--
2.21.0
- Re: [Qemu-devel] [PULL 0/6] Linux user for 4.1 patches, Peter Maydell, 2019/07/01
- [Qemu-devel] [PULL 0/6] Linux user for 4.1 patches, Laurent Vivier, 2019/07/02
- [Qemu-devel] [PULL 1/6] linux-user: Add support for translation of statx() syscall, Laurent Vivier, 2019/07/02
- [Qemu-devel] [PULL 6/6] linux-user: move QEMU_IFLA_BR_MULTI_BOOLOPT to the good function, Laurent Vivier, 2019/07/02
- [Qemu-devel] [PULL 2/6] linux-user: Add support for strace for statx() syscall, Laurent Vivier, 2019/07/02
- [Qemu-devel] [PULL 5/6] linux-user: Handle EXCP_FPE properly for MIPS,
Laurent Vivier <=
- [Qemu-devel] [PULL 4/6] linux-user: Introduce TARGET_HAVE_ARCH_STRUCT_FLOCK, Laurent Vivier, 2019/07/02
- [Qemu-devel] [PULL 3/6] linux-user: Fix target_flock structure for MIPS O64 ABI, Laurent Vivier, 2019/07/02
- Re: [Qemu-devel] [PULL 0/6] Linux user for 4.1 patches, no-reply, 2019/07/02
- Re: [Qemu-devel] [PULL 0/6] Linux user for 4.1 patches, no-reply, 2019/07/02
- Re: [Qemu-devel] [PULL 0/6] Linux user for 4.1 patches, no-reply, 2019/07/02
- Re: [Qemu-devel] [PULL 0/6] Linux user for 4.1 patches, no-reply, 2019/07/02
- Re: [Qemu-devel] [PULL 0/6] Linux user for 4.1 patches, no-reply, 2019/07/03
- Re: [Qemu-devel] [PULL 0/6] Linux user for 4.1 patches, no-reply, 2019/07/03
- Re: [Qemu-devel] [PULL 0/6] Linux user for 4.1 patches, Peter Maydell, 2019/07/03