[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/8] target/arm: Restrict semi-hosting to TCG
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v4 2/8] target/arm: Restrict semi-hosting to TCG |
Date: |
Tue, 2 Jul 2019 14:58:37 +0100 |
On Mon, 1 Jul 2019 at 20:50, Philippe Mathieu-Daudé <address@hidden> wrote:
>
> Per Peter Maydell:
>
> Semihosting hooks either SVC or HLT instructions, and inside KVM
> both of those go to EL1, ie to the guest, and can't be trapped to
> KVM.
>
> Let check_for_semihosting() return False when not running on TCG.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> v3: inline call to g_assert_not_reached if !TCG
> v4: fixed some ifdef that had moved in the next patch (Peter)
> ---
> target/arm/Makefile.objs | 2 +-
> target/arm/cpu.h | 7 +++++++
> target/arm/helper.c | 8 +++++++-
> 3 files changed, 15 insertions(+), 2 deletions(-)
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-devel] [PATCH v4 0/8] Support disabling TCG on ARM, Philippe Mathieu-Daudé, 2019/07/01
- [Qemu-devel] [PATCH v4 1/8] target/arm: Move debug routines to debug_helper.c, Philippe Mathieu-Daudé, 2019/07/01
- [Qemu-devel] [PATCH v4 8/8] target/arm: Do not build TCG objects when TCG is off, Philippe Mathieu-Daudé, 2019/07/01
- [Qemu-devel] [PATCH v4 4/8] RFC target/arm: Restrict pre-ARMv7 cpus to TCG, Philippe Mathieu-Daudé, 2019/07/01
- [Qemu-devel] [PATCH v4 7/8] RFC target/arm: Do not build A/M-profile cpus when using KVM, Philippe Mathieu-Daudé, 2019/07/01
- [Qemu-devel] [PATCH v4 3/8] target/arm/helper: Move M profile routines to m_helper.c, Philippe Mathieu-Daudé, 2019/07/01
- [Qemu-devel] [PATCH v4 6/8] RFC target/arm: Restrict R and M profiles to TCG, Philippe Mathieu-Daudé, 2019/07/01
- [Qemu-devel] [PATCH v4 2/8] target/arm: Restrict semi-hosting to TCG, Philippe Mathieu-Daudé, 2019/07/01
- Re: [Qemu-devel] [PATCH v4 2/8] target/arm: Restrict semi-hosting to TCG,
Peter Maydell <=
- [Qemu-devel] [PATCH v4 5/8] RFC target/arm: Do not build pre-ARMv7 cpus when using KVM, Philippe Mathieu-Daudé, 2019/07/01
- Re: [Qemu-devel] [PATCH v4 0/8] Support disabling TCG on ARM, Peter Maydell, 2019/07/02
- Re: [Qemu-devel] [PATCH v4 0/8] Support disabling TCG on ARM, no-reply, 2019/07/02
- Re: [Qemu-devel] [PATCH v4 0/8] Support disabling TCG on ARM, no-reply, 2019/07/03