[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tests: Update DSDT ACPI table for arm/virt boar
Re: [Qemu-devel] [PATCH] tests: Update DSDT ACPI table for arm/virt board with PCDIMM related changes
Tue, 2 Jul 2019 11:52:50 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0
On 7/2/19 11:43 AM, Philippe Mathieu-Daudé wrote:
> On 7/2/19 11:01 AM, Auger Eric wrote:
>> Hi Philippe,
>> On 7/2/19 10:56 AM, Philippe Mathieu-Daudé wrote:
>>> Hi Eric,
>>> On 7/1/19 9:08 PM, Eric Auger wrote:
>>>> PCDIMM hotplug addition updated the DSDT. Update the reference table.
>>> Can you point the commit sha1 please?
>> this follows Peter's make check failure report sent yesterday and
>> follow-up discussion on IRC. The series is not yet upstream so I cannot
>> point to any SHA1 yet.
> I hadn't review this series, so this patch was making no sense at all to
> me, now it does.
> I think it has to be squashed with:
> "hw/arm/virt: Enable device memory cold/hot plug with ACPI boot"
> in the series you mentioned.
Yep sorry for that. I was trying to fix the issue quickly for unblocking
the series for 4.1.
Actually it looks really weird as the test is passing on some hosts
(Igor is currently experiencing it). At the beginning I was not able to
reproduce Peter's issue and eventually after many various tweaks in the
environment I was able to. I used the script to regenerate the DSDT and
this definitively fixes the issue for me. Now we are not sure this isn't
an issue in the test itself.
>>>> Signed-off-by: Eric Auger <address@hidden>
>>>> tests/data/acpi/virt/DSDT | Bin 18476 -> 18493 bytes
>>>> 1 file changed, 0 insertions(+), 0 deletions(-)
>>>> diff --git a/tests/data/acpi/virt/DSDT b/tests/data/acpi/virt/DSDT
>>>> GIT binary patch
>>>> delta 172
>>>> delta 134