[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/3] net: tap: refactor net_bridge_run_helper
P J P
Re: [Qemu-devel] [PATCH v3 3/3] net: tap: refactor net_bridge_run_helper routine
Tue, 2 Jul 2019 13:38:58 +0530 (IST)
+-- On Mon, 1 Jul 2019, Li Qiang wrote --+
| You do two things here(avoid buffer formatting and get rid of calling
| shell), I would suggest you split these into split patch.
Both are related, 'helper_cmd' formatting was used with the shell invocation
helper_cmd = "qemu-bridge-helper --use-vnet --fd=sv --br=bridge"
execv("/bin/sh", "sh", "-c", helper_cmd, NULL);
The 'else' part wherein 'helper' is a /path/to/qemu-bridge-helper binary, it
is invoked without shell "sh" and 'helper_cmd' formatting.
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F