[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/6] hw/arm: Use ARM_CPU_TYPE_NAME() and object_
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 0/6] hw/arm: Use ARM_CPU_TYPE_NAME() and object_initialize_child() |
Date: |
Mon, 1 Jul 2019 19:16:24 +0100 |
On Mon, 1 Jul 2019 at 19:13, Philippe Mathieu-Daudé <address@hidden> wrote:
>
> On 7/1/19 7:56 PM, address@hidden wrote:
> > Patchew URL: https://patchew.org/QEMU/address@hidden/
> >
> > Hi,
> >
> > This series failed build test on s390x host. Please find the details below.
> >
> > CC hw/dma/i8257.o
> > CC hw/dma/xilinx_axidma.o
> > /var/tmp/patchew-tester-tmp-6umc5eop/src/hw/dma/xilinx_axidma.c: In
> > function ‘xilinx_axidma_init’:
> > /var/tmp/patchew-tester-tmp-6umc5eop/src/hw/dma/xilinx_axidma.c:568:29:
> > error: ‘TYPE_XILINX_AXI_ENET_DATA_STREAM’ undeclared (first use in this
> > function); did you mean ‘TYPE_XILINX_AXI_DMA_DATA_STREAM’?
> > 568 | TYPE_XILINX_AXI_ENET_DATA_STREAM,
> > &error_abort,
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > | TYPE_XILINX_AXI_DMA_DATA_STREAM
> > /var/tmp/patchew-tester-tmp-6umc5eop/src/hw/dma/xilinx_axidma.c:568:29:
> > note: each undeclared identifier is reported only once for each function it
> > appears in
> > /var/tmp/patchew-tester-tmp-6umc5eop/src/hw/dma/xilinx_axidma.c:572:29:
> > error: ‘TYPE_XILINX_AXI_ENET_CONTROL_STREAM’ undeclared (first use in this
> > function); did you mean ‘TYPE_XILINX_AXI_DMA_CONTROL_STREAM’?
> > 572 | TYPE_XILINX_AXI_ENET_CONTROL_STREAM,
> > &error_abort,
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > | TYPE_XILINX_AXI_DMA_CONTROL_STREAM
>
> It would be nice if GCC directly fix the patch instead of embarrassing
> the author for obvious copy/paste mistakes...
Sufficiently new gcc supports -fdiagnostics-generate-patch, and you could
probably script up a wrapper to automatically apply the patches ;-)
thanks
-- PMM
- Re: [Qemu-devel] [PATCH 5/6] hw/dma/xilinx_axi: Use object_initialize_child for correct ref. counting, (continued)
- [Qemu-devel] [PATCH 6/6] hw/net/xilinx_axi: Use object_initialize_child for correct ref. counting, Philippe Mathieu-Daudé, 2019/07/01
- [Qemu-devel] [PATCH 3/6] hw/arm: Use sysbus_init_child_obj for correct reference counting, Philippe Mathieu-Daudé, 2019/07/01
- [Qemu-devel] [PATCH 4/6] hw/arm/fsl-imx: Add the cpu as child of the SoC object, Philippe Mathieu-Daudé, 2019/07/01
- Re: [Qemu-devel] [PATCH 0/6] hw/arm: Use ARM_CPU_TYPE_NAME() and object_initialize_child(), Philippe Mathieu-Daudé, 2019/07/01
- Re: [Qemu-devel] [PATCH 0/6] hw/arm: Use ARM_CPU_TYPE_NAME() and object_initialize_child(), no-reply, 2019/07/01