[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 37/50] translator: inject instrumentation fro
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v3 37/50] translator: inject instrumentation from plugins |
Date: |
Mon, 01 Jul 2019 17:01:18 +0100 |
User-agent: |
mu4e 1.3.2; emacs 26.1 |
Richard Henderson <address@hidden> writes:
> On 6/14/19 10:11 AM, Alex Bennée wrote:
>> @@ -95,6 +103,10 @@ void translator_loop(const TranslatorOps *ops,
>> DisasContextBase *db,
>> ops->translate_insn(db, cpu);
>> }
>>
>> + if (plugin_enabled) {
>> + plugin_gen_insn_end();
>> + }
>> +
>> /* Stop translation if translate_insn so indicated. */
>> if (db->is_jmp != DISAS_NEXT) {
>
> This will of course not be reachable if db->is_jmp == DISAS_NORETURN.
> Do we want to not bother calling the plugin for this case?
Swap the order and add a comment?
--
Alex Bennée
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v3 37/50] translator: inject instrumentation from plugins,
Alex Bennée <=