qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/


From: Laurent Vivier
Subject: Re: [Qemu-devel] [Qemu-trivial] Fix cacheline size retrieval on FreeBSD/PowerPC(64)
Date: Mon, 1 Jul 2019 15:17:06 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0

Le 01/07/2019 à 15:02, Justin Hibbits a écrit :
> 
> 
> On Mon, Jul 1, 2019, 03:54 Laurent Vivier <address@hidden
> <mailto:address@hidden>> wrote:
> 
>     Le 27/06/2019 à 02:15, Justin Hibbits a écrit :
>     >
>     >
>     > On Wed, Jun 26, 2019, 19:08 Laurent Vivier <address@hidden
>     <mailto:address@hidden>
>     > <mailto:address@hidden <mailto:address@hidden>>> wrote:
>     >
>     >     Le 27/06/2019 à 02:02, Justin Hibbits a écrit :
>     >     >
>     >     >
>     >     > On Wed, Jun 26, 2019, 13:04 Justin Hibbits
>     <address@hidden <mailto:address@hidden>
>     >     <mailto:address@hidden <mailto:address@hidden>>
>     >     > <mailto:address@hidden <mailto:address@hidden>
>     <mailto:address@hidden <mailto:address@hidden>>>> wrote:
>     >     >
>     >     >     On Wed, 26 Jun 2019 18:47:42 +0200
>     >     >     Laurent Vivier <address@hidden
>     <mailto:address@hidden> <mailto:address@hidden
>     <mailto:address@hidden>>
>     >     <mailto:address@hidden <mailto:address@hidden>
>     <mailto:address@hidden <mailto:address@hidden>>>> wrote:
>     >     >
>     >     >     > Le 26/06/2019 à 18:37, Justin Hibbits a écrit :
>     >     >     > > On Wed, 26 Jun 2019 18:16:36 +0200
>     >     >     > > Laurent Vivier <address@hidden
>     <mailto:address@hidden>
>     >     <mailto:address@hidden <mailto:address@hidden>>
>     <mailto:address@hidden <mailto:address@hidden>
>     >     <mailto:address@hidden <mailto:address@hidden>>>> wrote:
>     >     >     > >   
>     >     >     > >> Le 26/06/2019 à 18:14, Laurent Vivier a écrit : 
>     >     >     > >>> Le 07/06/2019 à 20:56, Justin Hibbits a écrit :   
>     >     >     > >>>> The attached very trivial patch fixes a startup bug
>     >     that prevents
>     >     >     > >>>> at least Qemu 3.1 and later from working on
>     >     FreeBSD/powerpc64.
>     >     >     > >>>>
>     >     >     > >>>> - Justin
>     >     >     > >>>>   
>     >     >     > >>>
>     >     >     > >>> Please don't send a patch in attachment but inlined in
>     >     the message
>     >     >     > >>> (you may use "git send-email" for that).
>     >     >     > >>>
>     >     >     > >>> This patch fixes "util: add cacheinfo" that has
>     changed
>     >     the type
>     >     >     > >>> from unsigned to long.
>     >     >     > >>>
>     >     >     > >>> You can add the following line in the commit message:
>     >     >     > >>>
>     >     >     > >>> Fixes: b255b2c8a548 ("util: add cacheinfo")
>     >     >     > >>>
>     >     >     > >>> Reviewed-by: Laurent Vivier <address@hidden
>     <mailto:address@hidden>
>     >     <mailto:address@hidden <mailto:address@hidden>>
>     >     >     <mailto:address@hidden <mailto:address@hidden>
>     <mailto:address@hidden <mailto:address@hidden>>>>
>     >     >     > >>>     
>     >     >     > >>
>     >     >     > >> CC: author of b255b2c8a548 ("util: add cacheinfo")
>     >     >     > >>
>     >     >     > >> Thanks,
>     >     >     > >> Laurent 
>     >     >     > >
>     >     >     > > Hi Laurent,
>     >     >     > >
>     >     >     > > Sorry.  I had never used git send-email before, so
>     wasn't
>     >     >     > > comfortable with it.  I just updated the commit message
>     >     with your
>     >     >     > > feedback and used git send-email to submit the
>     patch.  I hope
>     >     >     > > everything went well. 
>     >     >     >
>     >     >     > It seems not. I didn't receive it.
>     >     >     >
>     >     >     > Did you configure the SMTP server. See git-send-email(1):
>     >     >     >
>     >     >     >    Use gmail as the smtp server
>     >     >     >
>     >     >     >        To use git send-email to send your patches through
>     >     the GMail
>     >     >     > SMTP server, edit ~/.gitconfig to specify your account
>     settings:
>     >     >     >
>     >     >     >            [sendemail]
>     >     >     >                    smtpEncryption = tls
>     >     >     >                    smtpServer = smtp.gmail.com
>     <http://smtp.gmail.com>
>     >     <http://smtp.gmail.com> <http://smtp.gmail.com>
>     >     >     >                    smtpUser = address@hidden
>     <mailto:address@hidden>
>     >     <mailto:address@hidden <mailto:address@hidden>>
>     >     >     <mailto:address@hidden <mailto:address@hidden>
>     <mailto:address@hidden <mailto:address@hidden>>>
>     >     >     >                    smtpServerPort = 587
>     >     >     >
>     >     >     >        If you have multifactor authentication setup on
>     your
>     >     gmail
>     >     >     > account, you will need to generate an app-specific
>     password
>     >     for use
>     >     >     > with git send-email. Visit
>     >     >     >       
>     >     https://security.google.com/settings/security/apppasswords to
>     >     >     > create it.
>     >     >     >
>     >     >     >        Once your commits are ready to be sent to the
>     mailing
>     >     list,
>     >     >     > run the following commands:
>     >     >     >
>     >     >     >            $ git format-patch --cover-letter -M
>     origin/master -o
>     >     >     > outgoing/ $ edit outgoing/0000-*
>     >     >     >            $ git send-email outgoing/*
>     >     >     >
>     >     >     >        The first time you run it, you will be prompted
>     for your
>     >     >     > credentials. Enter the app-specific or your regular
>     password as
>     >     >     > appropriate. If you have credential helper configured (see
>     >     >     > git-credential(1)), the password will be saved in the
>     credential
>     >     >     > store so you won’t have to type it the next time.
>     >     >     >
>     >     >     >        Note: the following perl modules are required
>     >     Net::SMTP::SSL,
>     >     >     >        MIME::Base64 and Authen::SASL
>     >     >     >
>     >     >     > Thanks,
>     >     >     > Laurent
>     >     >     >
>     >     >     > 
>     >     >
>     >     >     Hm, you're right.  Even after making the config changes and
>     >     installing
>     >     >     the necessary packages, I still have no luck with git
>     >     send-email.  Might
>     >     >     take a bit to debug this.
>     >     >
>     >     >     - Justin
>     >     >
>     >     >
>     >     > Sorry for the multiplicity, looks like Gmail forwarded it
>     eventually,
>     >     > but not until I tried several times debugging it.
>     >
>     >     Not sure, I didn't receive any of them.
>     >
>     >     Thanks,
>     >     Laurent
>     >
>     >
>     > Sigh, 4 copies ended up in my Gmail spam folder, so I thought it
>     made it
>     > through.
>     >
> 
>     Any news? Freeze is coming.
> 
>     Thanks,
>     Laurent
> 
> 
> I'll manually do it when I get home tomorrow.  Fixing git send-email
> will have to wait.

Don't bother: if you have problems with "git send-email" I can apply the
attachment.

Thanks,
Laurent



reply via email to

[Prev in Thread] Current Thread [Next in Thread]