Re: [Qemu-devel] [PATCH v5 20/28] hw/block/pflash_cfi02: Split if() condition

[Alistair Francis]

On Thu, Jun 27, 2019 at 1:44 PM Philippe Mathieu-Daudé
<address@hidden> wrote:
>
> Split the if() condition check and arrange the indentation to
> ease the review of the next patches. No logical change.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>

Reviewed-by: Alistair Francis <address@hidden>

Alistair

> ---
>  hw/block/pflash_cfi02.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
> index a0d3bd60dc..08b2bc83cb 100644
> --- a/hw/block/pflash_cfi02.c
> +++ b/hw/block/pflash_cfi02.c
> @@ -309,8 +309,10 @@ static void pflash_write(void *opaque, hwaddr offset, 
> uint64_t value,
>
>      trace_pflash_io_write(offset, width, width << 1, value, pfl->wcycle);
>      cmd = value;
> -    if (pfl->cmd != 0xA0 && cmd == 0xF0) {
> -        goto reset_flash;
> +    if (pfl->cmd != 0xA0) {
> +        if (cmd == 0xF0) {
> +            goto reset_flash;
> +        }
>      }
>      offset &= pfl->chip_len - 1;
>
> --
> 2.20.1
>
>