[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-bridge-helper: restrict bridge name to IFN
|
From: |
P J P |
|
Subject: |
Re: [Qemu-devel] [PATCH] qemu-bridge-helper: restrict bridge name to IFNAMSIZ |
|
Date: |
Fri, 28 Jun 2019 17:32:50 +0530 (IST) |
+-- On Fri, 28 Jun 2019, Daniel P. Berrangé wrote --+
| Ok, so we should explicitly report an error if the user supplied bridge name
| is too long, not silently truncate it.
|
| We should also report an error if config file has too long a bridge name.
Okay, ie. report error and exit?
+-- On Fri, 28 Jun 2019, Li Qiang wrote --+
| I think we should cleanup the bridge in the final.
I did free(bridge) first, it showed build error because 'bridge' is declared
as const char *, not sure why, didn't want to make patch too intrusive. If we
exit like Dan suggests above, guess it wouldn't be required.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F