Re: [Qemu-devel] [PATCH v15 0/5] linux-user: A set of miscellaneous patches

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH v15 0/5] linux-user: A set of miscellaneous patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
8e36bc8 linux-user: Handle EXCP_FPE properly for MIPS
8d588de linux-user: Introduce TARGET_HAVE_ARCH_STRUCT_FLOCK
9f12ce3 linux-user: Fix target_flock structure for MIPS O64 ABI
c3af4f1 linux-user: Add support for strace for statx() syscall
b00199b linux-user: Add support for translation of statx() syscall

=== OUTPUT BEGIN ===
1/5 Checking commit b00199b2c730 (linux-user: Add support for translation of 
statx() syscall)
WARNING: architecture specific defines should be avoided
#53: FILE: linux-user/syscall.c:321:
+#if defined(TARGET_NR_statx) && defined(__NR_statx)

WARNING: architecture specific defines should be avoided
#65: FILE: linux-user/syscall.c:6478:
+#if defined(TARGET_NR_statx) && defined(__NR_statx)

WARNING: architecture specific defines should be avoided
#135: FILE: linux-user/syscall.c:10188:
+#if defined(__NR_statx)

total: 0 errors, 3 warnings, 179 lines checked

Patch 1/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/5 Checking commit c3af4f1f9421 (linux-user: Add support for strace for 
statx() syscall)
ERROR: storage class should be at the beginning of the declaration
#27: FILE: linux-user/strace.c:979:
+UNUSED static struct flags statx_flags[] = {

ERROR: storage class should be at the beginning of the declaration
#49: FILE: linux-user/strace.c:1001:
+UNUSED static struct flags statx_mask[] = {

total: 2 errors, 0 warnings, 104 lines checked

Patch 2/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/5 Checking commit 9f12ce370693 (linux-user: Fix target_flock structure for 
MIPS O64 ABI)
4/5 Checking commit 8d588de6f092 (linux-user: Introduce 
TARGET_HAVE_ARCH_STRUCT_FLOCK)
5/5 Checking commit 8e36bc871a28 (linux-user: Handle EXCP_FPE properly for MIPS)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden