[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v14 5/5] linux-user: Handle EXCP_FPE properly fo
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH v14 5/5] linux-user: Handle EXCP_FPE properly for MIPS |
Date: |
Thu, 27 Jun 2019 19:17:49 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
Le 27/06/2019 à 17:31, Aleksandar Markovic a écrit :
> From: Aleksandar Markovic <address@hidden>
>
> Handle EXCP_FPE properly for MIPS in cpu loop.
>
> Note that a vast majority of FP instructions are not affected by
> the absence of the code in this patch, as they use alternative code
> paths for handling floating point exceptions (see, for example,
> invocations of update_fcr31()) - they rely on softfloat library for
> keeping track on exceptions that needs to be raised. However, there
> are few MIPS FP instructions (an example is CTC1) that use function
> do_raise_exception() directly, and they need the case that is added
> in this patch to propagate the FPE exception as designed.
>
> Reported-by: Yunqiang Su <address@hidden>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---
> linux-user/mips/cpu_loop.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/linux-user/mips/cpu_loop.c b/linux-user/mips/cpu_loop.c
> index 43ba267..7d3c6b9 100644
> --- a/linux-user/mips/cpu_loop.c
> +++ b/linux-user/mips/cpu_loop.c
> @@ -540,6 +540,12 @@ done_syscall:
> info.si_code = TARGET_ILL_ILLOPC;
> queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
> break;
> + case EXCP_FPE:
> + info.si_signo = TARGET_SIGFPE;
> + info.si_errno = 0;
> + info.si_code = 0;
> + queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
> + break;
> /* The code below was inspired by the MIPS Linux kernel trap
> * handling code in arch/mips/kernel/traps.c.
> */
>
I think you should set si_code according to FCSR Cause bits.
See force_fcr31_sig() in arch/mips/kernel/traps.c.
Thanks,
Laurent
- [Qemu-devel] [PATCH v14 0/5] linux-user: A set of miscellaneous patches, Aleksandar Markovic, 2019/06/27
- [Qemu-devel] [PATCH v14 2/5] linux-user: Add support for strace for statx() syscall, Aleksandar Markovic, 2019/06/27
- [Qemu-devel] [PATCH v14 1/5] linux-user: Add support for translation of statx() syscall, Aleksandar Markovic, 2019/06/27
- [Qemu-devel] [PATCH v14 4/5] linux-user: Introduce TARGET_HAVE_ARCH_STRUCT_FLOCK, Aleksandar Markovic, 2019/06/27
- [Qemu-devel] [PATCH v14 5/5] linux-user: Handle EXCP_FPE properly for MIPS, Aleksandar Markovic, 2019/06/27
- Re: [Qemu-devel] [PATCH v14 5/5] linux-user: Handle EXCP_FPE properly for MIPS,
Laurent Vivier <=
- [Qemu-devel] [PATCH v14 3/5] linux-user: Fix flock structure for MIPS O64 ABI, Aleksandar Markovic, 2019/06/27
- Re: [Qemu-devel] [PATCH v14 0/5] linux-user: A set of miscellaneous patches, no-reply, 2019/06/27
- Re: [Qemu-devel] [PATCH v14 0/5] linux-user: A set of miscellaneous patches, no-reply, 2019/06/27