[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 0/3] virtio-scsi: restart DMA after iothread
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v5 0/3] virtio-scsi: restart DMA after iothread |
Date: |
Thu, 27 Jun 2019 13:03:44 +0200 |
User-agent: |
Mutt/1.11.3 (2019-02-01) |
Am 20.06.2019 um 19:37 hat Stefan Hajnoczi geschrieben:
> v5:
> * Plumbing vm change state handlers into DeviceClass/BusClass is a rather
> large bug fix. Instead I've combined the previous priorities approach with
> the observation from Kevin and Paolo that we really want to order by qdev
> tree depth.
>
> The new qdev_add_vm_change_state_handler() API lets DeviceStates register
> callbacks that execute in qdev tree depth order. This solves the
> virtio-scsi bug since the virtio-scsi device's callback must complete
> before
> its child scsi-disk's callback runs.
>
> Is this a good compromise for everyone?
I'd still call it a hack, but I can also see that doing the real thing
would be a lot of work that might not be worth the effort.
Thanks, applied to the block branch.
Kevin