[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 08/17] dma/rc4030: Fix off-by-one error in specified
From: |
Aleksandar Markovic |
Subject: |
[Qemu-devel] [PULL 08/17] dma/rc4030: Fix off-by-one error in specified memory region size |
Date: |
Wed, 26 Jun 2019 13:45:41 +0200 |
From: Aleksandar Markovic <address@hidden>
The size is one byte less than it should be:
address-space: rc4030-dma
0000000000000000-00000000fffffffe (prio 0, i/o): rc4030.dma
rc4030 is used in MIPS Jazz board context.
Signed-off-by: Aleksandar Markovic <address@hidden>
Reviewed-by: Aleksandar Rikalo <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
---
hw/dma/rc4030.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/dma/rc4030.c b/hw/dma/rc4030.c
index 6ccafec..88ff271 100644
--- a/hw/dma/rc4030.c
+++ b/hw/dma/rc4030.c
@@ -23,6 +23,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu/units.h"
#include "hw/hw.h"
#include "hw/mips/mips.h"
#include "hw/sysbus.h"
@@ -678,7 +679,7 @@ static void rc4030_realize(DeviceState *dev, Error **errp)
memory_region_init_iommu(&s->dma_mr, sizeof(s->dma_mr),
TYPE_RC4030_IOMMU_MEMORY_REGION,
- o, "rc4030.dma", UINT32_MAX);
+ o, "rc4030.dma", 4 * GiB);
address_space_init(&s->dma_as, MEMORY_REGION(&s->dma_mr), "rc4030-dma");
}
--
2.7.4
- [Qemu-devel] [PULL 00/17] MIPS queue for June 2016th, 2019, Aleksandar Markovic, 2019/06/26
- [Qemu-devel] [PULL 04/17] hw/mips/gt64xxx_pci: Fix 'spaces' coding style issues, Aleksandar Markovic, 2019/06/26
- [Qemu-devel] [PULL 03/17] hw/mips/gt64xxx_pci: Fix 'braces' coding style issues, Aleksandar Markovic, 2019/06/26
- [Qemu-devel] [PULL 07/17] hw/mips/gt64xxx_pci: Align the pci0-mem size, Aleksandar Markovic, 2019/06/26
- [Qemu-devel] [PULL 09/17] dma/rc4030: Minor code style cleanup, Aleksandar Markovic, 2019/06/26
- [Qemu-devel] [PULL 01/17] hw/mips/gt64xxx_pci: Fix multiline comment syntax, Aleksandar Markovic, 2019/06/26
- [Qemu-devel] [PULL 08/17] dma/rc4030: Fix off-by-one error in specified memory region size,
Aleksandar Markovic <=
- [Qemu-devel] [PULL 05/17] hw/mips/gt64xxx_pci: Use qemu_log_mask() instead of debug printf(), Aleksandar Markovic, 2019/06/26
- [Qemu-devel] [PULL 02/17] hw/mips/gt64xxx_pci: Fix 'tabs' coding style issues, Aleksandar Markovic, 2019/06/26
- [Qemu-devel] [PULL 11/17] tests/tcg: target/mips: Add tests for MSA move instructions, Aleksandar Markovic, 2019/06/26
- [Qemu-devel] [PULL 06/17] hw/mips/gt64xxx_pci: Convert debug printf()s to trace events, Aleksandar Markovic, 2019/06/26
- [Qemu-devel] [PULL 17/17] target/mips: Fix big endian host behavior for interleave MSA instructions, Aleksandar Markovic, 2019/06/26
- [Qemu-devel] [PULL 16/17] tests/tcg: target/mips: Fix some test cases for pack MSA instructions, Aleksandar Markovic, 2019/06/26
- [Qemu-devel] [PULL 12/17] tests/tcg: target/mips: Amend tests for MSA int dot product instructions, Aleksandar Markovic, 2019/06/26
- [Qemu-devel] [PULL 13/17] tests/tcg: target/mips: Amend tests for MSA int multiply instructions, Aleksandar Markovic, 2019/06/26
- [Qemu-devel] [PULL 10/17] tests/tcg: target/mips: Add tests for MSA bit move instructions, Aleksandar Markovic, 2019/06/26
- [Qemu-devel] [PULL 14/17] tests/tcg: target/mips: Add support for MSA big-endian target testings, Aleksandar Markovic, 2019/06/26