Re: [Qemu-devel] [PATCH] ioapic: clear irq_eoi when updating the ioapic redirect table entry

[Paolo Bonzini]

On 24/06/19 17:16, Li Qiang wrote:
> irq_eoi is used to count the number of irq injected during eoi
> broadcast. It should be set to 0 when updating the ioapic's redirect
> table entry.
> 
> Suggested-by: Peter Xu <address@hidden>
> Signed-off-by: Li Qiang <address@hidden>
> ---
>  hw/intc/ioapic.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c
> index 7074489fdf..db9e518602 100644
> --- a/hw/intc/ioapic.c
> +++ b/hw/intc/ioapic.c
> @@ -380,6 +380,7 @@ ioapic_mem_write(void *opaque, hwaddr addr, uint64_t val,
>                  /* restore RO bits */
>                  s->ioredtbl[index] &= IOAPIC_RW_BITS;
>                  s->ioredtbl[index] |= ro_bits;
> +                s->irq_eoi[index] = 0;
>                  ioapic_fix_edge_remote_irr(&s->ioredtbl[index]);
>                  ioapic_service(s);
>              }
> 

Queued, thanks.

Paolo