[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v12 2/5] linux-user: Add support for setsockopt(
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH v12 2/5] linux-user: Add support for setsockopt() option SOL_ALG |
Date: |
Mon, 24 Jun 2019 23:01:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
Le 19/06/2019 à 16:17, Aleksandar Markovic a écrit :
> From: Yunqiang Su <address@hidden>
>
> Add support for options SOL_ALG of the syscall setsockopt(). This
> option is used in relation to Linux kernel Crypto API, and allows
> a user to set additional information for the cipher operation via
> syscall setsockopt(). The field "optname" must be one of the
> following:
>
> - ALG_SET_KEY – seting the key
> - ALG_SET_AEAD_AUTHSIZE – set the authentication tag size
>
> SOL_ALG is relatively newer setsockopt() option. Therefore, the
> code that handles SOL_ALG is enclosed in "ifdef" so that the build
> does not fail for older kernels that do not contain support for
> SOL_ALG. "ifdef" also contains check if ALG_SET_KEY and
> ALG_SET_AEAD_AUTHSIZE are defined.
>
> Signed-off-by: Yunqiang Su <address@hidden>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> Reviewed-by: Laurent Vivier <address@hidden>
> ---
> linux-user/syscall.c | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index f267ad0..d116287 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -102,6 +102,7 @@
> #include <linux/blkpg.h>
> #include <netpacket/packet.h>
> #include <linux/netlink.h>
> +#include <linux/if_alg.h>
> #include "linux_loop.h"
> #include "uname.h"
>
> @@ -1989,6 +1990,36 @@ static abi_long do_setsockopt(int sockfd, int level,
> int optname,
> goto unimplemented;
> }
> break;
> +#if defined(SOL_ALG) && defined(ALG_SET_KEY) &&
> defined(ALG_SET_AEAD_AUTHSIZE)
> + case SOL_ALG:
> + switch (optname) {
> + case ALG_SET_KEY:
> + {
> + char *alg_key = g_malloc(optlen);
> +
> + if (!alg_key) {
> + return -TARGET_ENOMEM;
> + }
> + if (copy_from_user(alg_key, optval_addr, optlen)) {
> + g_free(alg_key);
> + return -TARGET_EFAULT;
> + }
> + ret = get_errno(setsockopt(sockfd, level, optname,
> + alg_key, optlen));
> + g_free(alg_key);
> + break;
> + }
> + case ALG_SET_AEAD_AUTHSIZE:
> + {
> + ret = get_errno(setsockopt(sockfd, level, optname,
> + NULL, optlen));
> + break;
> + }
> + default:
> + goto unimplemented;
> + }
> + break;
> +#endif
> case TARGET_SOL_SOCKET:
> switch (optname) {
> case TARGET_SO_RCVTIMEO:
>
Applied to my linux-user branch.
Thanks,
Laurent
[Qemu-devel] [PATCH v12 4/5] linux-user: Add support for strace for statx() syscall, Aleksandar Markovic, 2019/06/19
Re: [Qemu-devel] [PATCH v12 0/5], no-reply, 2019/06/19