[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 7/8] Revert xen/io/ring.h of "Clean up a few header g
From: |
Anthony PERARD |
Subject: |
[Qemu-devel] [PULL 7/8] Revert xen/io/ring.h of "Clean up a few header guard symbols" |
Date: |
Mon, 24 Jun 2019 16:32:56 +0100 |
This reverts changes to include/hw/xen/io/ring.h from commit
37677d7db39a3c250ad661d00fb7c3b59d047b1f.
Following 37677d7db3 "Clean up a few header guard symbols", QEMU start
to fail to build:
In file included from ~/xen/tools/../tools/include/xen/io/blkif.h:31:0,
from ~/xen/tools/qemu-xen-dir/hw/block/xen_blkif.h:5,
from ~/xen/tools/qemu-xen-dir/hw/block/xen-block.c:22:
~/xen/tools/../tools/include/xen/io/ring.h:68:0: error: "__CONST_RING_SIZE"
redefined [-Werror]
#define __CONST_RING_SIZE(_s, _sz) \
In file included from ~/xen/tools/qemu-xen-dir/hw/block/xen_blkif.h:4:0,
from ~/xen/tools/qemu-xen-dir/hw/block/xen-block.c:22:
~/xen/tools/qemu-xen-dir/include/hw/xen/io/ring.h:66:0: note: this is the
location of the previous definition
#define __CONST_RING_SIZE(_s, _sz) \
The issue is that some public xen headers have been imported (by
f65eadb639 "xen: import ring.h from xen") but not all. With the change
in the guards symbole, the ring.h header start to be imported twice.
Signed-off-by: Anthony PERARD <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Paul Durrant <address@hidden>
Message-Id: <address@hidden>
---
include/hw/xen/io/ring.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/hw/xen/io/ring.h b/include/hw/xen/io/ring.h
index 62abfd7a6e..1adacf09f9 100644
--- a/include/hw/xen/io/ring.h
+++ b/include/hw/xen/io/ring.h
@@ -24,8 +24,8 @@
* Tim Deegan and Andrew Warfield November 2004.
*/
-#ifndef XEN_PUBLIC_IO_RING_H
-#define XEN_PUBLIC_IO_RING_H
+#ifndef __XEN_PUBLIC_IO_RING_H__
+#define __XEN_PUBLIC_IO_RING_H__
/*
* When #include'ing this header, you need to provide the following
@@ -469,7 +469,7 @@ struct name##_data_intf {
\
}; \
DEFINE_XEN_FLEX_RING(name)
-#endif /* XEN_PUBLIC_IO_RING_H */
+#endif /* __XEN_PUBLIC_IO_RING_H__ */
/*
* Local variables:
--
Anthony PERARD
- [Qemu-devel] [PULL 0/8] xen queue 2019-06-24, Anthony PERARD, 2019/06/24
- [Qemu-devel] [PULL 3/8] xen-bus: allow AioContext to be specified for each event channel, Anthony PERARD, 2019/06/24
- [Qemu-devel] [PULL 2/8] xen-bus: use a separate fd for each event channel, Anthony PERARD, 2019/06/24
- [Qemu-devel] [PULL 1/8] xen-block: support feature-large-sector-size, Anthony PERARD, 2019/06/24
- [Qemu-devel] [PULL 4/8] xen-bus / xen-block: add support for event channel polling, Anthony PERARD, 2019/06/24
- [Qemu-devel] [PULL 6/8] xen: Drop includes of xen/hvm/params.h, Anthony PERARD, 2019/06/24
- [Qemu-devel] [PULL 5/8] xen: Avoid VLA, Anthony PERARD, 2019/06/24
- [Qemu-devel] [PULL 7/8] Revert xen/io/ring.h of "Clean up a few header guard symbols",
Anthony PERARD <=
- [Qemu-devel] [PULL 8/8] xen: Import other xen/io/*.h, Anthony PERARD, 2019/06/24
- Re: [Qemu-devel] [Xen-devel] [PULL 0/8] xen queue 2019-06-24, no-reply, 2019/06/24
- Re: [Qemu-devel] [Xen-devel] [PULL 0/8] xen queue 2019-06-24, no-reply, 2019/06/24
- Re: [Qemu-devel] [Xen-devel] [PULL 0/8] xen queue 2019-06-24, no-reply, 2019/06/24
- Re: [Qemu-devel] [Xen-devel] [PULL 0/8] xen queue 2019-06-24, no-reply, 2019/06/24
- Re: [Qemu-devel] [Xen-devel] [PULL 0/8] xen queue 2019-06-24, no-reply, 2019/06/24