qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC] checkpatch: do not warn for multiline paren


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH RFC] checkpatch: do not warn for multiline parenthesized returned value
Date: Mon, 24 Jun 2019 11:00:51 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)

Paolo Bonzini <address@hidden> writes:

> While indeed we do not want to have
>
>     return (a);
>
> it is less clear that this applies to
>
>     return (a &&
>             b);
>
> Some editors indent more nicely if you have parentheses, and some people's
> eyes may appreciate that as well.

No objection.

> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  scripts/checkpatch.pl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index c2aaf42..2f81371 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2296,7 +2296,8 @@ sub process {
>                              $value =~ s/\([^\(\)]*\)/1/) {
>                       }
>  #print "value<$value>\n";
> -                     if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/) {
> +                     if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/ &&
> +                         $line =~ /;$/) {
>                               ERROR("return is not a function, parentheses 
> are not required\n" . $herecurr);
>  
>                       } elsif ($spacing !~ /\s+/) {




reply via email to

[Prev in Thread] Current Thread [Next in Thread]